Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable modes with balanced GC for AArch64 #97

Merged
merged 1 commit into from
May 28, 2021
Merged

Enable modes with balanced GC for AArch64 #97

merged 1 commit into from
May 28, 2021

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Aug 5, 2020

This commit enables modes with balanced GC for AArch64.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k knn-k marked this pull request as draft August 5, 2020 01:35
@knn-k knn-k mentioned this pull request Aug 5, 2020
Closed
@smlambert smlambert requested a review from renfeiw August 5, 2020 01:47
@karianna karianna added the enhancement New feature or request label Aug 6, 2020
@karianna karianna added this to the August 2020 milestone Aug 6, 2020
@karianna karianna modified the milestones: August 2020, September 2020 Sep 7, 2020
@karianna karianna modified the milestones: September 2020, October 2020 Oct 5, 2020
@karianna karianna modified the milestones: October 2020, November 2020 Nov 6, 2020
@karianna karianna modified the milestones: November 2020, December 2020 Dec 2, 2020
@karianna karianna modified the milestones: December 2020, January 2021 Jan 5, 2021
@karianna karianna modified the milestones: January 2021, February 2021 Feb 3, 2021
@knn-k
Enable modes with balanced GC for AArch64
7fb14a9 
This commit enables modes with balanced GC for AArch64.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k knn-k mentioned this pull request Feb 8, 2021
Merged
@karianna karianna modified the milestones: February 2021, March 2021 Mar 18, 2021
@karianna karianna modified the milestones: March 2021, April 2021 Apr 1, 2021
@karianna karianna modified the milestones: April 2021, May 2021 May 4, 2021
@smlambert
Copy link
Contributor

What is the state of this draft @knn-k ? Is the intention to still bring it in eventually ?

@knn-k
Copy link
Contributor Author

knn-k commented May 11, 2021

I am still waiting for eclipse-openj9/openj9#10320 to be reviewed.

@knn-k knn-k marked this pull request as ready for review May 28, 2021 11:28
@knn-k
Copy link
Contributor Author

knn-k commented May 28, 2021

eclipse-openj9/openj9#10320 is merged now.

renfeiw
renfeiw approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@renfeiw renfeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smlambert smlambert merged commit d7b69a6 into adoptium:master May 28, 2021
@knn-k knn-k deleted the aarch64settings2 branch May 29, 2021 00:47
@knn-k knn-k mentioned this pull request Jun 3, 2021
Closed
knn-k added a commit to knn-k/TKG that referenced this pull request Jun 7, 2021
@knn-k
Revert "Enable modes with balanced GC for AArch64"
a820366 
Revert adoptium#97 for the time being, as failures were found with balanced GC on AArch64.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k knn-k mentioned this pull request Jun 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

@renfeiw renfeiw renfeiw approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
May 2021
Development

Successfully merging this pull request may close these issues.
4 participants
@knn-k @smlambert @renfeiw @karianna