Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#27 Add tests for typed client [stacked PR #5.1] #1140

Merged
merged 5 commits into from
Feb 26, 2022

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Feb 21, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-#123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. Assign PR to reviewer

Notes for Reviewer

This PR contains the tests for #1089

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
    • Each unit test case has a unique UUID
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido self-assigned this Feb 21, 2022
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch 3 times, most recently from 078ac6a to b02a50f Compare February 21, 2022 20:07
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api-tests branch from 22236b8 to 960d9fc Compare February 21, 2022 20:48
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api branch from 780d83b to a0310be Compare February 22, 2022 14:32
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api-tests branch from 960d9fc to aa5793b Compare February 22, 2022 16:15
Base automatically changed from iox-#27-add-typed-client-and-server-api to master February 22, 2022 18:41
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api-tests branch from aa5793b to c7bc62f Compare February 24, 2022 23:33
@elBoberido elBoberido changed the base branch from master to iox-#27-use-cxx-expected-for-client-and-server-send-method February 24, 2022 23:41
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api-tests branch 3 times, most recently from 85fc544 to 6bf7dae Compare February 25, 2022 01:36
@elBoberido elBoberido marked this pull request as ready for review February 25, 2022 01:37
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api-tests branch from 69194b6 to 752f3b6 Compare February 25, 2022 12:51
@elBoberido elBoberido changed the title [do-not-review] iox-#27 Add tests for typed client [stacked PR #5.1] iox-#27 Add tests for typed client [stacked PR #5.1] Feb 25, 2022
mossmaurice
mossmaurice previously approved these changes Feb 25, 2022
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elBoberido elBoberido force-pushed the iox-#27-use-cxx-expected-for-client-and-server-send-method branch from a880ffa to 481f42e Compare February 25, 2022 14:21
@elBoberido elBoberido force-pushed the iox-#27-add-typed-client-and-server-api-tests branch 2 times, most recently from 9b3877a to b9aecf2 Compare February 25, 2022 15:43
elfenpiff
elfenpiff previously approved these changes Feb 25, 2022
Base automatically changed from iox-#27-use-cxx-expected-for-client-and-server-send-method to master February 25, 2022 17:51
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #1140 (6d6587d) into master (acd70e6) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   78.56%   78.69%   +0.13%     
==========================================
  Files         357      366       +9     
  Lines       14526    14604      +78     
  Branches     2038     2042       +4     
==========================================
+ Hits        11412    11493      +81     
+ Misses       2442     2440       -2     
+ Partials      672      671       -1     
Flag Coverage Δ
unittests 77.91% <ø> (+0.13%) ⬆️
unittests_timing 13.92% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...include/iceoryx_posh/internal/popo/client_impl.hpp 100.00% <ø> (ø)
...include/iceoryx_posh/internal/popo/server_impl.hpp 100.00% <ø> (ø)
iceoryx_hoofs/source/posix_wrapper/timer.cpp 63.90% <0.00%> (ø)
...clude/iceoryx_posh/internal/popo/rpc_interface.hpp 100.00% <0.00%> (ø)
...de/iceoryx_posh/internal/popo/response_deleter.inl 100.00% <0.00%> (ø)
...sh/include/iceoryx_posh/internal/popo/response.inl 100.00% <0.00%> (ø)
...ude/iceoryx_posh/internal/popo/request_deleter.inl 100.00% <0.00%> (ø)
...osh/include/iceoryx_posh/internal/popo/request.inl 100.00% <0.00%> (ø)
...include/iceoryx_posh/internal/popo/server_impl.inl 100.00% <0.00%> (ø)
... and 3 more

@elBoberido elBoberido merged commit 163b70f into master Feb 26, 2022
@elBoberido elBoberido deleted the iox-#27-add-typed-client-and-server-api-tests branch February 26, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants