-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iox-#27 Add tests for typed client [stacked PR #5.1] #1140
Merged
elBoberido
merged 5 commits into
master
from
iox-#27-add-typed-client-and-server-api-tests
Feb 26, 2022
Merged
iox-#27 Add tests for typed client [stacked PR #5.1] #1140
elBoberido
merged 5 commits into
master
from
iox-#27-add-typed-client-and-server-api-tests
Feb 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api
branch
3 times, most recently
from
February 21, 2022 20:07
078ac6a
to
b02a50f
Compare
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api-tests
branch
from
February 21, 2022 20:48
22236b8
to
960d9fc
Compare
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api
branch
from
February 22, 2022 14:32
780d83b
to
a0310be
Compare
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api-tests
branch
from
February 22, 2022 16:15
960d9fc
to
aa5793b
Compare
Base automatically changed from
iox-#27-add-typed-client-and-server-api
to
master
February 22, 2022 18:41
21 tasks
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api-tests
branch
from
February 24, 2022 23:33
aa5793b
to
c7bc62f
Compare
elBoberido
changed the base branch from
master
to
iox-#27-use-cxx-expected-for-client-and-server-send-method
February 24, 2022 23:41
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api-tests
branch
3 times, most recently
from
February 25, 2022 01:36
85fc544
to
6bf7dae
Compare
21 tasks
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api-tests
branch
from
February 25, 2022 12:51
69194b6
to
752f3b6
Compare
elBoberido
changed the title
[do-not-review] iox-#27 Add tests for typed client [stacked PR #5.1]
iox-#27 Add tests for typed client [stacked PR #5.1]
Feb 25, 2022
mossmaurice
previously approved these changes
Feb 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
elBoberido
force-pushed
the
iox-#27-use-cxx-expected-for-client-and-server-send-method
branch
from
February 25, 2022 14:21
a880ffa
to
481f42e
Compare
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api-tests
branch
2 times, most recently
from
February 25, 2022 15:43
9b3877a
to
b9aecf2
Compare
elfenpiff
previously approved these changes
Feb 25, 2022
Base automatically changed from
iox-#27-use-cxx-expected-for-client-and-server-send-method
to
master
February 25, 2022 17:51
elBoberido
force-pushed
the
iox-#27-add-typed-client-and-server-api-tests
branch
from
February 25, 2022 17:52
b9aecf2
to
6d6587d
Compare
elfenpiff
approved these changes
Feb 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #1140 +/- ##
==========================================
+ Coverage 78.56% 78.69% +0.13%
==========================================
Files 357 366 +9
Lines 14526 14604 +78
Branches 2038 2042 +4
==========================================
+ Hits 11412 11493 +81
+ Misses 2442 2440 -2
+ Partials 672 671 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FerdinandSpitzschnueffler
approved these changes
Feb 26, 2022
mossmaurice
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
This PR contains the tests for #1089
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References