-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move all tests into an anonymous namespace #563
Closed
6 tasks done
Labels
good first issue
Good for newcomers
refactoring
Refactor code without adding features
test
A module/integration/stress/etc test for a component
Comments
elBoberido
added
refactoring
Refactor code without adding features
test
A module/integration/stress/etc test for a component
good first issue
Good for newcomers
labels
Feb 16, 2021
19 tasks
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
Apr 1, 2021
…s namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
19 tasks
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
Apr 1, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
Apr 1, 2021
…s namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
Apr 1, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
Apr 1, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
Apr 1, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
that referenced
this issue
Apr 3, 2021
…letests-into-anonymous-namespace Iox #563 move tests in utils moduletests into anonymous namespace
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
Apr 3, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 11, 2021
… namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 11, 2021
…ymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
19 tasks
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 11, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 11, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
marthtz
pushed a commit
to boschglobal/iceoryx
that referenced
this issue
May 12, 2021
…s namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
marthtz
pushed a commit
to boschglobal/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
marthtz
pushed a commit
to boschglobal/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
marthtz
pushed a commit
to boschglobal/iceoryx
that referenced
this issue
May 12, 2021
…s-in-utils-moduletests-into-anonymous-namespace Iox eclipse-iceoryx#563 move tests in utils moduletests into anonymous namespace
marthtz
pushed a commit
to boschglobal/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
… namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
…ymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 12, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
that referenced
this issue
May 14, 2021
…anonymous-namespace Iox #563 move tests in posh into anonymous namespace
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…ymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…onymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…onymous namespaces Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
19 tasks
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…ymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…onymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…onymous namespaces Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…ymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…onymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
…onymous namespaces Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
to ApexAI/iceoryx
that referenced
this issue
May 19, 2021
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
added a commit
that referenced
this issue
May 20, 2021
…and-dds-into-anonymous-namespace Iox #563 move tests in binding c and dds into anonymous namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
good first issue
Good for newcomers
refactoring
Refactor code without adding features
test
A module/integration/stress/etc test for a component
Brief feature description
All tests should be self contained in an anonymous namespace.
Detailed information
Multiple tests files are linked together into one binary. If the tests are not put into an unique namespace, it is possible that multiple helper structs with the same name but different layout are in the same binary. With luck, the linker complains. With bad luck, the address sanitizer detects some weird errors after doing something totally unrelated. Like renaming test files in #561 which lead to a different ordering in the compilation process and made the address sanitizer complain about heap buffer overflow due to 4 tests having a
DummyData
struct and one of them had a different layout.TODO:
The text was updated successfully, but these errors were encountered: