-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #563 move tests in utils moduletests into anonymous namespace #667
Merged
elBoberido
merged 3 commits into
eclipse-iceoryx:release_1.0
from
ApexAI:iox-#563-move-tests-in-utils-moduletests-into-anonymous-namespace
Apr 3, 2021
Merged
Iox #563 move tests in utils moduletests into anonymous namespace #667
elBoberido
merged 3 commits into
eclipse-iceoryx:release_1.0
from
ApexAI:iox-#563-move-tests-in-utils-moduletests-into-anonymous-namespace
Apr 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release_1.0 #667 +/- ##
===============================================
- Coverage 74.36% 74.34% -0.02%
===============================================
Files 318 318
Lines 11204 11204
Branches 1963 1963
===============================================
- Hits 8332 8330 -2
- Misses 2100 2101 +1
- Partials 772 773 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…s namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
force-pushed
the
iox-#563-move-tests-in-utils-moduletests-into-anonymous-namespace
branch
from
April 1, 2021 19:22
90469d2
to
e3c95b9
Compare
elBoberido
requested review from
elfenpiff,
mossmaurice and
FerdinandSpitzschnueffler
April 1, 2021 19:23
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
force-pushed
the
iox-#563-move-tests-in-utils-moduletests-into-anonymous-namespace
branch
from
April 1, 2021 19:39
c9ee0dc
to
64354f0
Compare
it seems this also fixes #666 |
dkroenke
previously approved these changes
Apr 3, 2021
budrus
previously approved these changes
Apr 3, 2021
elBoberido
dismissed stale reviews from budrus and dkroenke
April 3, 2021 10:03
The base branch was changed.
budrus
approved these changes
Apr 3, 2021
dkroenke
approved these changes
Apr 3, 2021
elBoberido
deleted the
iox-#563-move-tests-in-utils-moduletests-into-anonymous-namespace
branch
April 3, 2021 10:05
marthtz
pushed a commit
to boschglobal/iceoryx
that referenced
this pull request
May 12, 2021
…s-in-utils-moduletests-into-anonymous-namespace Iox eclipse-iceoryx#563 move tests in utils moduletests into anonymous namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Just to check if this fixes the leak sanitizer issue
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References