Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #563 move tests in utils moduletests into anonymous namespace #667

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Apr 1, 2021

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

Just to check if this fixes the leak sanitizer issue

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #667 (64354f0) into release_1.0 (79db27b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           release_1.0     #667      +/-   ##
===============================================
- Coverage        74.36%   74.34%   -0.02%     
===============================================
  Files              318      318              
  Lines            11204    11204              
  Branches          1963     1963              
===============================================
- Hits              8332     8330       -2     
- Misses            2100     2101       +1     
- Partials           772      773       +1     
Flag Coverage Δ
unittests 74.30% <ø> (-0.02%) ⬇️
unittests_timing 31.20% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/iceoryx_utils/internal/objectpool/objectpool.hpp 89.40% <ø> (ø)
iceoryx_utils/source/posix_wrapper/timer.cpp 59.64% <0.00%> (-0.88%) ⬇️
...ils/include/iceoryx_utils/internal/cxx/smart_c.inl 89.06% <0.00%> (ø)

…s namespace

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
@elBoberido elBoberido force-pushed the iox-#563-move-tests-in-utils-moduletests-into-anonymous-namespace branch from 90469d2 to e3c95b9 Compare April 1, 2021 19:22
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
@elBoberido elBoberido force-pushed the iox-#563-move-tests-in-utils-moduletests-into-anonymous-namespace branch from c9ee0dc to 64354f0 Compare April 1, 2021 19:39
@elBoberido elBoberido self-assigned this Apr 1, 2021
@elBoberido elBoberido added the technical debt unclean code and design flaws label Apr 1, 2021
@elBoberido
Copy link
Member Author

it seems this also fixes #666

dkroenke
dkroenke previously approved these changes Apr 3, 2021
budrus
budrus previously approved these changes Apr 3, 2021
@elBoberido elBoberido changed the base branch from master to release_1.0 April 3, 2021 10:03
@elBoberido elBoberido dismissed stale reviews from budrus and dkroenke April 3, 2021 10:03

The base branch was changed.

@budrus budrus requested review from budrus and dkroenke April 3, 2021 10:04
@elBoberido elBoberido merged commit e8e55c1 into eclipse-iceoryx:release_1.0 Apr 3, 2021
@elBoberido elBoberido deleted the iox-#563-move-tests-in-utils-moduletests-into-anonymous-namespace branch April 3, 2021 10:05
@budrus budrus linked an issue Apr 6, 2021 that may be closed by this pull request
marthtz pushed a commit to boschglobal/iceoryx that referenced this pull request May 12, 2021
…s-in-utils-moduletests-into-anonymous-namespace

Iox eclipse-iceoryx#563 move tests in utils moduletests into anonymous namespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt unclean code and design flaws
Projects
None yet
3 participants