Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #563 move tests in binding c and dds into anonymous namespace #800

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented May 19, 2021

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Branch follows the naming format (iox-#123-this-is-a-branch)
  4. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  5. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  6. Relevant issues are linked
  7. Add sensible notes for the reviewer
  8. All checks have passed (except task-list-completed)
  9. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

@elBoberido elBoberido added the technical debt unclean code and design flaws label May 19, 2021
@elBoberido elBoberido self-assigned this May 19, 2021
@elBoberido elBoberido force-pushed the iox-#563-move-tests-in-binding-c-and-dds-into-anonymous-namespace branch from 787393b to e45658a Compare May 19, 2021 19:23
@codecov
Copy link

codecov bot commented May 19, 2021

Codecov Report

Merging #800 (cafaf0c) into master (2334abe) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #800      +/-   ##
==========================================
+ Coverage   74.34%   74.37%   +0.02%     
==========================================
  Files         322      322              
  Lines       11522    11522              
  Branches     1952     1952              
==========================================
+ Hits         8566     8569       +3     
+ Misses       2195     2194       -1     
+ Partials      761      759       -2     
Flag Coverage Δ
unittests 73.19% <ø> (+0.01%) ⬆️
unittests_timing 30.92% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
iceoryx_hoofs/source/posix_wrapper/timer.cpp 61.90% <0.00%> (+0.43%) ⬆️
...nternal/roudi/introspection/port_introspection.inl 72.62% <0.00%> (+0.72%) ⬆️

…ymous namespace

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
…onymous namespace

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
…onymous namespaces

Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
@elBoberido elBoberido force-pushed the iox-#563-move-tests-in-binding-c-and-dds-into-anonymous-namespace branch from e45658a to cafaf0c Compare May 19, 2021 19:51
Copy link
Contributor

@mossmaurice mossmaurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elBoberido elBoberido merged commit e6be1f7 into eclipse-iceoryx:master May 20, 2021
@elBoberido elBoberido deleted the iox-#563-move-tests-in-binding-c-and-dds-into-anonymous-namespace branch May 20, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt unclean code and design flaws
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move all tests into an anonymous namespace
3 participants