-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iox #563 move tests in binding c and dds into anonymous namespace #800
Merged
elBoberido
merged 4 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#563-move-tests-in-binding-c-and-dds-into-anonymous-namespace
May 20, 2021
Merged
Iox #563 move tests in binding c and dds into anonymous namespace #800
elBoberido
merged 4 commits into
eclipse-iceoryx:master
from
ApexAI:iox-#563-move-tests-in-binding-c-and-dds-into-anonymous-namespace
May 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elBoberido
force-pushed
the
iox-#563-move-tests-in-binding-c-and-dds-into-anonymous-namespace
branch
from
May 19, 2021 19:23
787393b
to
e45658a
Compare
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
==========================================
+ Coverage 74.34% 74.37% +0.02%
==========================================
Files 322 322
Lines 11522 11522
Branches 1952 1952
==========================================
+ Hits 8566 8569 +3
+ Misses 2195 2194 -1
+ Partials 761 759 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…ymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
…onymous namespace Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
…onymous namespaces Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
force-pushed
the
iox-#563-move-tests-in-binding-c-and-dds-into-anonymous-namespace
branch
from
May 19, 2021 19:51
e45658a
to
cafaf0c
Compare
dkroenke
approved these changes
May 20, 2021
mossmaurice
approved these changes
May 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
elBoberido
deleted the
iox-#563-move-tests-in-binding-c-and-dds-into-anonymous-namespace
branch
May 20, 2021 08:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch
)iox-#123 commit text
)git commit -s
)task-list-completed
)Notes for Reviewer
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References