Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Align the argument order of dbWriteTable() with the DBI specs #49

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Dec 3, 2023

Fix #43

@eitsupi
Copy link
Contributor Author

eitsupi commented Feb 18, 2024

@krlmlr Is there any reason why this would not be merged? Is there anything I can do?

@krlmlr krlmlr changed the title fix: change the argument order of dbWriteTable fix: change the argument order of dbWriteTable() Feb 22, 2024
@krlmlr krlmlr changed the title fix: change the argument order of dbWriteTable() fix: Align the argument order of dbWriteTable() with the DBI specs Feb 22, 2024
@krlmlr
Copy link
Collaborator

krlmlr commented Feb 22, 2024

Thanks. Running revdepchecks now.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.89%. Comparing base (1c9c1a8) to head (682b170).
Report is 2 commits behind head on main.

❗ Current head 682b170 differs from pull request most recent head 263f399. Consider uploading reports for the commit 263f399 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #49   +/-   ##
=======================================
  Coverage   85.89%   85.89%           
=======================================
  Files         106      106           
  Lines        3602     3602           
=======================================
  Hits         3094     3094           
  Misses        508      508           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krlmlr
Copy link
Collaborator

krlmlr commented Feb 22, 2024

Uploaded results, one package has new failures. Could you please take a look?

@eitsupi
Copy link
Contributor Author

eitsupi commented Feb 23, 2024

Uploaded results, one package has new failures. Could you please take a look?

I have looked and found that the results were also different in duckdb installed from R-universe, so I think this is due to a change in the order of the records returned by duckdb and this PR is irrelevant.
https://github.com/darwin-eu-dev/PatientProfiles/blob/97f8a26ffede8ce09c98aece9ca67c43fa97db28/tests/testthat/test-addCategories.R#L25-L30

@eitsupi
Copy link
Contributor Author

eitsupi commented Feb 23, 2024

I've send a PR for fix the test cases darwin-eu-dev/PatientProfiles#456.

@krlmlr krlmlr merged commit 3f48286 into duckdb:main Feb 23, 2024
18 checks passed
@krlmlr
Copy link
Collaborator

krlmlr commented Feb 23, 2024

Thanks, also for double-checking!

@eitsupi eitsupi deleted the arg-order branch February 23, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbWriteTable's arguments order
3 participants