Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix the tests for duckdb 0.10 #456

Closed
wants to merge 1 commit into from
Closed

test: fix the tests for duckdb 0.10 #456

wants to merge 1 commit into from

Conversation

eitsupi
Copy link

@eitsupi eitsupi commented Feb 23, 2024

The new version of duckdb seems to have changed the order of the rows and the test fails (See duckdb/duckdb-r#49 (comment)).
I think we must be sure to reorder them here to guarantee the order.

@catalamarti
Copy link
Collaborator

Hi @eitsupi thank for the PR.
Due to the internal policy of our project we cant accept external contributions. So this PR wont be merged, but I will make sure this is fixed in the next release.
Thanks

@eitsupi eitsupi deleted the patch-1 branch February 25, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants