Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] refactor entropy #93466

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Oct 13, 2023

Fixes #93398

  • the real fix is addressing know issue
    • "In some cases, instanceof SharedArrayBuffer returns false even though buffer is an SAB."
  • I did it by refactoring away pal_random.lib.js and including the logic into the rest of the TypeScript code we have
    • because we already have existing solution for it

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Oct 13, 2023
@pavelsavara pavelsavara added this to the 9.0.0 milestone Oct 13, 2023
@pavelsavara pavelsavara self-assigned this Oct 13, 2023
@ghost
Copy link

ghost commented Oct 13, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #93398

  • the real fix is addressing know issue In some cases, instanceof SharedArrayBuffer returns false even though buffer is an SAB.
  • I did it by refactoring away pal_random.lib.js and including the logic into the rest of the TypeScript code we have
Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript, os-browser

Milestone: 9.0.0

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pavelsavara
Copy link
Member Author

/azp run runtime-wasm

@pavelsavara pavelsavara marked this pull request as ready for review October 14, 2023 16:58
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radekdoulik
Copy link
Member

the debugger failure is #89409

@pavelsavara pavelsavara merged commit ee9dd81 into dotnet:main Oct 16, 2023
193 of 198 checks passed
@pavelsavara pavelsavara deleted the browser_refactor_entropy branch October 16, 2023 10:07
ilonatommy added a commit to ilonatommy/runtime that referenced this pull request Oct 26, 2023
ilonatommy added a commit that referenced this pull request Oct 31, 2023
…94051)

* Disabling tests failing in the last two weeks on MT.

* Failures from #93466 should not apply.

* Remove duplicate + other issues connnected to test PR runs.

* Cleanup

* Increasing num of threads instead of disabling.

* Update System.Threading.ThreadPool.Tests.csproj

16 was too low, still failing

* Update System.Threading.ThreadPool.Tests.csproj

32 was failing
@ghost ghost locked as resolved and limited conversation to collaborators Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[wasm] MT browser-bench crash
2 participants