Test failure: JIT/jit64/rtchecks/overflow/overflow02_mul/overflow02_mul.dll #93442
Comments
BruceForstall
added
arch-arm64
os-windows
blocking-clean-ci
dotnet-issue-labeler
bot
added
the
needs-area-label
|
I see the following diff between altjit (left) and native arm64 windows jit:
Seems likely MSVC is miscompiling |
|
Indeed, MSVC seems to miscompile the core Notice that the Edit: I've opened https://developercommunity.visualstudio.com/t/arm64-compiler-incorrectly-optimizes-an/10491353 |
jakobbotsch
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBuild InformationBuild: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=436667 Error Message{
"ErrorMessage": "Failed test: JIT/jit64/rtchecks/overflow/overflow02_mul/overflow02_mul.dll",
"ErrorPattern": "",
"BuildRetry": false,
"ExcludeConsoleLog": false
}Report
Summary
Known issue validationBuild: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=436667
|
jakobbotsch
added
disabled-test
|
I marked this "blocking-release" for .NET 8 because I presume (needs to be verified) the compilers used to build .NET 8 were updated as well, since the tests also failed on a release/7.0 build. |
|
Should we revert the compiler update on the build machines in the meantime? I do not think we can afford to wait for the compiler fix to be released. |
If we can easily do that that may be safest. Alternatively we can try to write the function in a different way as a work around. |
Isn’t overflow UB? |
I do not see C/C++ level overflow in the code snippet. The values are widened to int64 so that there is no overflow at C/C++ level and the actual overflow can be detected. |
We are trying to upgrade the compilers for #92234 . Trying to downgrade at the same is going to make things complicated. I am trying workaround with disabled optimizations for the affected method: #93523 |
|
Test no longer disabled, with #93523 |
BruceForstall
removed
blocking-release
disabled-test
Diff: https://github.com/dotnet/runtime/compare/256bf22a3ddf920516752701da2b95e1847ff708..6f7af556d2761b0c93299cb88c61e4b747d6176a From: dotnet/runtime@256bf22 To: dotnet/runtime@6f7af55 Commits: - Fix draining response in metrics test (#93381) dotnet/runtime@7082fb3 - [release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#93283) dotnet/runtime@7a84b55 - [release/8.0] JIT: Fix exponential blowup of memory dependency arrays in VNForMapSelectWork (#93388) dotnet/runtime@735d1ed - Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2290133 (#93422) dotnet/runtime@c47e96c - [release/8.0] Fix Options Source Gen with Length attributes applied on properties of Interface type (#93482) dotnet/runtime@fb1d8b4 - Optimize Options Source Gen when no need to run (#93481) dotnet/runtime@ae26d3e - Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20231012.4 (#93470) dotnet/runtime@a731309 - [release/8.0][wasm] Update workload description to include target framework (#93359) dotnet/runtime@9e8d548 - [release/8.0] Adjust System.Net metrics for OTel conformance and consistency (#93414) dotnet/runtime@60b77a6 - Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2291029 (#93496) dotnet/runtime@1878c55 - Workaround for dotnet/runtime#93442 (#93528) dotnet/runtime@324f912 - TcpReceiveSendGetsCanceledByDispose: update test for change in Linux kernel. (#93502) dotnet/runtime@5a43d62 - Mention Frozen.* types in PACKAGE.md for System.Collections.Immutable (#93561) dotnet/runtime@567f81e - [release/8.0] [hot reload][debugger] Resolve field types before use (#93559) dotnet/runtime@9e5c741 - [release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#93549) dotnet/runtime@5a61c77 - [release/8.0] Update dependencies from 7 repositories (#93282) dotnet/runtime@fbd7b65 - Update dependencies from https://github.com/dotnet/roslyn build 20231017.7 (#93628) dotnet/runtime@6f7af55 [[ commit created by automation ]]
Diff: https://github.com/dotnet/runtime/compare/256bf22a3ddf920516752701da2b95e1847ff708..6f7af556d2761b0c93299cb88c61e4b747d6176a From: dotnet/runtime@256bf22 To: dotnet/runtime@6f7af55 Commits: - Fix draining response in metrics test (#93381) dotnet/runtime@7082fb3 - [release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#93283) dotnet/runtime@7a84b55 - [release/8.0] JIT: Fix exponential blowup of memory dependency arrays in VNForMapSelectWork (#93388) dotnet/runtime@735d1ed - Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2290133 (#93422) dotnet/runtime@c47e96c - [release/8.0] Fix Options Source Gen with Length attributes applied on properties of Interface type (#93482) dotnet/runtime@fb1d8b4 - Optimize Options Source Gen when no need to run (#93481) dotnet/runtime@ae26d3e - Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20231012.4 (#93470) dotnet/runtime@a731309 - [release/8.0][wasm] Update workload description to include target framework (#93359) dotnet/runtime@9e8d548 - [release/8.0] Adjust System.Net metrics for OTel conformance and consistency (#93414) dotnet/runtime@60b77a6 - Localized file check-in by OneLocBuild Task: Build definition ID 679: Build ID 2291029 (#93496) dotnet/runtime@1878c55 - Workaround for dotnet/runtime#93442 (#93528) dotnet/runtime@324f912 - TcpReceiveSendGetsCanceledByDispose: update test for change in Linux kernel. (#93502) dotnet/runtime@5a43d62 - Mention Frozen.* types in PACKAGE.md for System.Collections.Immutable (#93561) dotnet/runtime@567f81e - [release/8.0] [hot reload][debugger] Resolve field types before use (#93559) dotnet/runtime@9e5c741 - [release/8.0] Update dependencies from dnceng/internal/dotnet-optimization (#93549) dotnet/runtime@5a61c77 - [release/8.0] Update dependencies from 7 repositories (#93282) dotnet/runtime@fbd7b65 - Update dependencies from https://github.com/dotnet/roslyn build 20231017.7 (#93628) dotnet/runtime@6f7af55 [[ commit created by automation ]]
ghost
locked as resolved and limited conversation to collaborators
dotnet-policy-service
bot
added
the
in-pr
Build Information
Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=436667
Build error leg or test failing: JIT/jit64/rtchecks/overflow/overflow02_mul/overflow02_mul.dll
Pull request: #93377
Error Message
{ "ErrorMessage": "Failed test: JIT/jit64/rtchecks/overflow/overflow02_mul/overflow02_mul.dll", "ErrorPattern": "", "BuildRetry": false, "ExcludeConsoleLog": false }Report
Summary
Known issue validation
Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=436667
Error message validated:
Failed test: JIT/jit64/rtchecks/overflow/overflow02_mul/overflow02_mul.dllResult validation: ✅ Known issue matched with the provided build.
Validation performed at: 10/13/2023 8:48:40 AM UTC
The text was updated successfully, but these errors were encountered: