Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy local intellisense xmls for assemblies with source of truth. #79134

Merged
merged 27 commits into from
Feb 1, 2023
Merged

Copy local intellisense xmls for assemblies with source of truth. #79134

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
02e8b58
Copy local intellisense xmls for assemblies with source of truth.
carlossanlop Dec 2, 2022
3227c67
use UseIntellisenseDocumentationFile instead
smasher164 Jan 3, 2023
175deee
Create intellisense.targets, which contains the Target that defines t…
carlossanlop Jan 10, 2023
33d63d8
Set UseIntellisenseDocumentationFile to true for the 3 assemblies tha…
carlossanlop Jan 10, 2023
4cdf926
Delete docs.targets, move package download to Build.proj
carlossanlop Jan 20, 2023
4785850
Consume $(XmlDocDir) in Microsoft.NetCore.App.Ref.sfxproj
carlossanlop Jan 20, 2023
27ae4a6
Change condition to import intellisense.targets: Use $(IsSourceProjec…
carlossanlop Jan 20, 2023
d5cbf96
Move XmlDocFileRoot to intellisense.targets, address suggestions for …
carlossanlop Jan 20, 2023
15ff2cd
Expand condition of CopyDocumentationFileToXmlDocDir to also check if…
carlossanlop Jan 20, 2023
4d3633d
Change AfterTargets of CopyDocumentationFileToXmlDocDir from CoreComp…
carlossanlop Jan 20, 2023
74a4b4e
Move PackageDownload to intellisense.targets
carlossanlop Jan 26, 2023
19249f5
Remove Choose+When. Readjust properties for Private.Intellisense file…
carlossanlop Jan 26, 2023
83773b7
Rename csproj property to something more clear.
carlossanlop Jan 27, 2023
ba8ac9a
Default csproj property to true.
carlossanlop Jan 27, 2023
8c39ea9
Missed adding the "not previously set" condition for UseIntellisenseP…
carlossanlop Jan 27, 2023
6197945
Remove incorrect condition in CopyDocumentationFileToXmlDocDir.
carlossanlop Jan 27, 2023
4d94daa
Missed property reuse in Condition in sfxproj
carlossanlop Jan 27, 2023
80d0d0d
Only evaluate second IntellisensePackageXmlFile if the first one did …
carlossanlop Jan 27, 2023
d2a60f9
Move intellisense.targets import from root to libraries, right after …
carlossanlop Jan 27, 2023
f4ce3cb
Enable CS1591, skip arcade warning
carlossanlop Jan 27, 2023
2c7048e
Move SkipArcadeNoWarnCS1591 to src/libraries/Directory.Build.props to…
carlossanlop Jan 27, 2023
459ce39
Remove unnecessary slashes in sfxproj
carlossanlop Jan 27, 2023
2d70d61
Move SkipArcadeNoWarn up to the top of src/libraries/Directory.Build.…
carlossanlop Jan 27, 2023
c689a05
Revert Brotli and Vectors csproj changes. Those assemblies are either…
carlossanlop Jan 31, 2023
4d3e550
Add target to intellisense.targets that runs as InitialTarget of the …
carlossanlop Jan 31, 2023
981d201
Improve error message: Mention the problematic property and the offen…
carlossanlop Feb 1, 2023
dc8ef9a
Added extra condition to verification target to only run when UseInte…
carlossanlop Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion eng/intellisense.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project>
<Project InitialTargets="VerifyAssemblySupportsDocsXmlGeneration">

<PropertyGroup>
<UseIntellisensePackageDocXmlFile Condition="'$(UseIntellisensePackageDocXmlFile)' == ''">true</UseIntellisensePackageDocXmlFile>
Expand All @@ -10,6 +10,11 @@
<IntellisensePackageXmlFile Condition="'$(IntellisensePackageXmlFile)' == '' and '$(UseIntellisensePackageDocXmlFile)' == 'true' and Exists($(IntellisensePackageXmlFileFromDotNetPlatExtFolder))">$(IntellisensePackageXmlFileFromDotNetPlatExtFolder)</IntellisensePackageXmlFile>
</PropertyGroup>

<Target Name="VerifyAssemblySupportsDocsXmlGeneration">
carlossanlop marked this conversation as resolved.
Show resolved Hide resolved
<Error Condition="'$(UseIntellisensePackageDocXmlFile)' == 'false' and '$(IsPartialFacadeAssembly)' == 'true'" Text="Cannot currently generate full xml documentation for an assembly that is a partial facade." />
carlossanlop marked this conversation as resolved.
Show resolved Hide resolved
carlossanlop marked this conversation as resolved.
Show resolved Hide resolved
<Error Condition="'$(UseIntellisensePackageDocXmlFile)' == 'false' and '$(GeneratePlatformNotSupportedAssemblyMessage)' != ''" Text="Cannot currently generate full xml documentation for an assembly that generates PNSE." />
carlossanlop marked this conversation as resolved.
Show resolved Hide resolved
</Target>

<ItemGroup>
<PackageDownload Include="Microsoft.Private.Intellisense" Version="[$(MicrosoftPrivateIntellisenseVersion)]" />
</ItemGroup>
Expand Down