Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy local intellisense xmls for assemblies with source of truth. #79134

Merged
merged 27 commits into from
Feb 1, 2023

Commits on Jan 25, 2023

  1. Configuration menu
    Copy the full SHA
    02e8b58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3227c67 View commit details
    Browse the repository at this point in the history
  3. Create intellisense.targets, which contains the Target that defines t…

    …he set of files to copy, and the Target that copies each of those files into the artifacts/bin/docs folder.
    
    The paths of the files to copy are dynamically defined depending if the assembly IsPackable property is set or not, and if the UseIntellisenseDocumentationFile boolean is set or not.
    carlossanlop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    175deee View commit details
    Browse the repository at this point in the history
  4. Set UseIntellisenseDocumentationFile to true for the 3 assemblies tha…

    …t already have their source of truth in triple slash.
    carlossanlop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    33d63d8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4cdf926 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4785850 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    27ae4a6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d5cbf96 View commit details
    Browse the repository at this point in the history
  9. Expand condition of CopyDocumentationFileToXmlDocDir to also check if…

    … IsNetCoreAppSrc == true.
    carlossanlop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    15ff2cd View commit details
    Browse the repository at this point in the history
  10. Change AfterTargets of CopyDocumentationFileToXmlDocDir from CoreComp…

    …ile to CopyFilesToOutputDirectory
    carlossanlop committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4d3633d View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Configuration menu
    Copy the full SHA
    74a4b4e View commit details
    Browse the repository at this point in the history
  2. Remove Choose+When. Readjust properties for Private.Intellisense file…

    …s/folders. Fix conditions for doc file swap.
    carlossanlop committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    19249f5 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Configuration menu
    Copy the full SHA
    83773b7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ba8ac9a View commit details
    Browse the repository at this point in the history
  3. Missed adding the "not previously set" condition for UseIntellisenseP…

    …ackageDocXmlFile in intellisense.targets.
    carlossanlop committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    8c39ea9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6197945 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4d94daa View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    80d0d0d View commit details
    Browse the repository at this point in the history
  7. Move intellisense.targets import from root to libraries, right after …

    …the IsNetCoreAppSrc property is declared so we can use it.
    carlossanlop committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    d2a60f9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f4ce3cb View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2c7048e View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    459ce39 View commit details
    Browse the repository at this point in the history
  11. Move SkipArcadeNoWarn up to the top of src/libraries/Directory.Build.…

    …props to ensure it gets loaded before importing arcade.
    carlossanlop committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    2d70d61 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Revert Brotli and Vectors csproj changes. Those assemblies are either…

    … a partial facade or use PNSE.
    carlossanlop committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    c689a05 View commit details
    Browse the repository at this point in the history
  2. Add target to intellisense.targets that runs as InitialTarget of the …

    …current project, and throws errors if the UseIntellisensePackageDocXmlFile is set to false and the assembly is either a partial facade or uses PNSE.
    carlossanlop committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    4d3e550 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Configuration menu
    Copy the full SHA
    981d201 View commit details
    Browse the repository at this point in the history
  2. Added extra condition to verification target to only run when UseInte…

    …llisense... is not set to true.
    
    Also moved the initial definition to its own solitary property group right before the verification target runs.
    
    Rename the properties that acquire the value of a file path to "FilePath" instead of just "File", for clarity.
    carlossanlop committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    dc8ef9a View commit details
    Browse the repository at this point in the history