Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy local intellisense xmls for assemblies with source of truth. #79134
Copy local intellisense xmls for assemblies with source of truth. #79134
Changes from 25 commits
02e8b58
3227c67
175deee
33d63d8
4cdf926
4785850
27ae4a6
d5cbf96
15ff2cd
4d3633d
74a4b4e
19249f5
83773b7
ba8ac9a
8c39ea9
6197945
4d94daa
80d0d0d
d2a60f9
f4ce3cb
2c7048e
459ce39
2d70d61
c689a05
4d3e550
981d201
dc8ef9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we just discussed, this might be too late to impact the result of a ProjectReference.
ProjectReferences (as used in the transport packages) only recieve the path to the dll in the bin folder and find the doc file relative to that.
To support ProjectReference we may want to swap the value of
@(DocFileItem)
instead and do so right beforeCopyFilesToOutputDirectory
. This will make it so that the "shipping" xml is always next to the binary in the bin folder. The compiler generated one (in the case it is not shipping) will remain in the obj folder.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's a sample that does this: ericstj@94849ba
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you verify that this works in a pack-only scenario as well? dotnet pack --no-build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some tests in a comment in the main thread.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realized that the
'$(TargetFramework)' == '$(NetCoreAppCurrent)'
condition results in a behavior difference and will force us to overbuild. When building the repo, by default only the nearest NetCoreAppCurrent tfm will be built. In the case of building on Windows, this means net8.0-windows or net8.0 if projects don't have a corresponding windows platform TFM.We should remove that artificial limitation and restore the previous behavior. I could see the following cases to apply:
I don't know if it's possible to determine the third case in an msbuild environment, but that's the default build behavior in dotnet/runtime and will be utilized in the VMR with RID builds. Therefore we should try to make that work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created an issue to track this: #82191
This file was deleted.