Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing dispose on rate limiting #76784

Conversation

AliKhalili
Copy link
Contributor

Proposed fix for #76783

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Oct 8, 2022
@ghost
Copy link

ghost commented Oct 8, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

Proposed fix for #76783

Author: AliKhalili
Assignees: -
Labels:

area-System.Threading

Milestone: -

@AliKhalili AliKhalili marked this pull request as ready for review October 8, 2022 19:56
@AliKhalili AliKhalili changed the title Fixe missing dispose on rate limiting Fix missing dispose on rate limiting Oct 12, 2022
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@BrennanConroy
Copy link
Member

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@BrennanConroy
Copy link
Member

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@BrennanConroy BrennanConroy merged commit 37bd664 into dotnet:main Nov 2, 2022
@BrennanConroy BrennanConroy added this to the 8.0.0 milestone Nov 2, 2022
@AliKhalili AliKhalili deleted the issue-76783-ratelimit-disposed-obsolete-request branch November 2, 2022 20:27
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Threading community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants