Fix missing dispose on rate limiting (#76784)

dotnet · Nov 2, 2022 · 37bd664 · 37bd664
1 parent d1c2960
commit 37bd664
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 0 deletions.
diff --git a/...ies/System.Threading.RateLimiting/src/System/Threading/RateLimiting/ConcurrencyLimiter.cs b/...ies/System.Threading.RateLimiting/src/System/Threading/RateLimiting/ConcurrencyLimiter.cs
@@ -161,6 +161,7 @@ protected override ValueTask<RateLimitLease> AcquireAsyncCore(int permitCount, C
                             {
                                 Interlocked.Increment(ref _failedLeasesCount);
                             }
+                            oldestRequest.CancellationTokenRegistration.Dispose();
                         }
                         while (_options.QueueLimit - _queueCount < permitCount);
                     }

diff --git a/...System.Threading.RateLimiting/src/System/Threading/RateLimiting/FixedWindowRateLimiter.cs b/...System.Threading.RateLimiting/src/System/Threading/RateLimiting/FixedWindowRateLimiter.cs
@@ -178,6 +178,7 @@ protected override ValueTask<RateLimitLease> AcquireAsyncCore(int permitCount, C
                             {
                                 Interlocked.Increment(ref _failedLeasesCount);
                             }
+                            oldestRequest.CancellationTokenRegistration.Dispose();
                         }
                         while (_options.QueueLimit - _queueCount < permitCount);
                     }

diff --git a/...stem.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs b/...stem.Threading.RateLimiting/src/System/Threading/RateLimiting/SlidingWindowRateLimiter.cs
@@ -190,6 +190,7 @@ protected override ValueTask<RateLimitLease> AcquireAsyncCore(int permitCount, C
                             {
                                 Interlocked.Increment(ref _failedLeasesCount);
                             }
+                            oldestRequest.CancellationTokenRegistration.Dispose();
                         }
                         while (_options.QueueLimit - _queueCount < permitCount);
                     }

diff --git a/...System.Threading.RateLimiting/src/System/Threading/RateLimiting/TokenBucketRateLimiter.cs b/...System.Threading.RateLimiting/src/System/Threading/RateLimiting/TokenBucketRateLimiter.cs
@@ -184,6 +184,7 @@ protected override ValueTask<RateLimitLease> AcquireAsyncCore(int tokenCount, Ca
                             {
                                 Interlocked.Increment(ref _failedLeasesCount);
                             }
+                            oldestRequest.CancellationTokenRegistration.Dispose();
                         }
                         while (_options.QueueLimit - _queueCount < tokenCount);
                     }