[release/7.0] Simplify and fix the Int128 *, /, and % logic #75567
Conversation
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
Co-authored-by: tfenise <tfenise@live.com>
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
CC. @jeffhandley |
|
@danmoseley can we please get an approval? |
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsBackport of #75470 to release/7.0 /cc @tannergooding Customer ImpactDevelopers utilizing these functions with specific inputs may get results that have the incorrect sign in the case of overflow TestingAdditional regression tests were added covering the highlighted scenarios. The logic was likewise simplified to help reduce the chance for error. RiskThis impacts types that are entirely new to .NET 7 and so the risk of breaking existing users is limited only to developers who have been utilizing the early previews.
|
|
Approved, new feature correctness |
|
@dakersnar @tannergooding do you see any concerning failures in the CI logs? I see a few failures. |
|
@carlossanlop, all tests passed on rerun. |
|
Great! So this has been approved, signed off, and the CI is green. Ready to merge. |
ghost
locked as resolved and limited conversation to collaborators
Backport of #75470 to release/7.0
/cc @tannergooding
Customer Impact
Developers utilizing these functions with specific inputs may get results that have the incorrect sign in the case of overflow
Testing
Additional regression tests were added covering the highlighted scenarios. The logic was likewise simplified to help reduce the chance for error.
Risk
This impacts types that are entirely new to .NET 7 and so the risk of breaking existing users is limited only to developers who have been utilizing the early previews.