Simplify and fix the Int128 *, /, and % logic #75470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned 
tfenise
suggested changes
Sep 12, 2022
Co-authored-by: tfenise <tfenise@live.com>
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis resolves #75416
|
dakersnar
approved these changes
Sep 12, 2022
|
|
||
| if (IsNegative(right)) | ||
| if (((upper != 0) || (lower < 0)) && ((~upper != 0) || (lower >= 0))) |
There was a problem hiding this comment.
Something about this logic is hard to parse but I can't figure out a better way to structure it.
|
Logged #75566 for the Mono llvmaot failure, which is unrelated. |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3048638350 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #75416