Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] Set configureplatform.make prerelease to 0 #74103

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

carlossanlop
Copy link
Member

As explained here: #72169 (comment) by @jkotas:

If we switch it to 0 in main, we will see C/C++ compiler warnings creep in. I do not think anybody wants to sign up for fixing them once we fork for .NET 8.

So I'm doing this directly in rc1. The maestro bot should get it backported to release/7.0 automatically.

@ghost
Copy link

ghost commented Aug 17, 2022

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

As explained here: #72169 (comment) by @jkotas:

If we switch it to 0 in main, we will see C/C++ compiler warnings creep in. I do not think anybody wants to sign up for fixing them once we fork for .NET 8.

So I'm doing this directly in rc1. The maestro bot should get it backported to release/7.0 automatically.

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: -

@carlossanlop
Copy link
Member Author

The CI failure is: #74122
Signed off.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 7ab10ff into dotnet:release/7.0-rc1 Aug 18, 2022
@carlossanlop carlossanlop deleted the PrereleaseRC1 branch August 18, 2022 02:50
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants