Remove IsPreRelease msbuild property #72169
Conversation
The property was added in dotnet/coreclr@809b8f7 years ago and isn't used anymore. Remove it to ease branding.
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsThe property was added in dotnet/coreclr@809b8f7 years ago and isn't used anymore. Remove it to ease branding.
|
eng/native/configureplatform.cmake
Outdated
| # If set, indicates that this is not an officially supported release | ||
| # Keep in sync with IsPrerelease in Directory.Build.props | ||
| # If set, indicates that this is not an officially supported release. | ||
| # Release branches should set this to false. | ||
| set(PRERELEASE 0) |
There was a problem hiding this comment.
Should this be set to 1 in main?
There was a problem hiding this comment.
This was recently switched to 0 by @carlossanlop in 40b3c36. I already reached out to him offline and explained that this doesn't need to be set before we actually release.
Do you think we should switch it back and make sure that it again gets changed to 0 in the release/7.0 branch?
There was a problem hiding this comment.
Do you think we should switch it back and make sure that it again gets changed to 0 in the release/7.0 branch?
Yes.
If we switch it to 0 in main, we will see C/C++ compiler warnings creep in. I do not think anybody wants to sign up for fixing them once we fork for .NET 8.
FWIW, it was also used by the Utf8String prototype a couple years after that and maybe others. But we do have better avenues to do this kind of things now with experimental features and runtimelab and deleting makes sense. |
ghost
locked as resolved and limited conversation to collaborators
The property was added in dotnet/coreclr@809b8f7 years ago and isn't used anymore. Remove it to ease branding.