[release/7.0-rc1] Don't set PublishAot in SDK by default #74048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
This was referenced Aug 17, 2022
MichalStrehovsky
approved these changes
Aug 17, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
Can we add rc1 branch for runtime-wasm? it will be useful for validations. |
It's not a change for this pull request. These props/targets are only included in NativeAOT test legs in this repo. SDK repo promotes them to being more than that but that's not observable here because we use the old targets that came with the SDK everywhere outside NativeAOT testing. That's why this wasn't broken in this repo originally either. |
lewing
approved these changes
Aug 17, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74046 to release/7.0-rc1
/cc @MichalStrehovsky @sbomer
Customer Impact
Testing
Risk
IMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.