Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Clean up AOT publish process" #74036

Closed
wants to merge 1 commit into from
Closed

Revert "Clean up AOT publish process" #74036

wants to merge 1 commit into from

Conversation

lewing
Copy link
Member

@lewing lewing commented Aug 17, 2022 •
edited
Loading

Reverts #73416 due to it setting PublishAot=true by default when used from the sdk dotnet/sdk#27149

@ghost ghost assigned lewing Aug 17, 2022
@lewing
Copy link
Member Author

lewing commented Aug 17, 2022

I opened this to get the ball rolling, an alternate fix is fine

@lewing lewing mentioned this pull request Aug 17, 2022
Merged
@lewing
Copy link
Member Author

lewing commented Aug 17, 2022

/backport to release/7.0-rc1

jeffschwMSFT
jeffschwMSFT approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

Started backporting to release/7.0-rc1: https://github.com/dotnet/runtime/actions/runs/2872017660

@github-actions github-actions bot mentioned this pull request Aug 17, 2022
Closed
@sbomer sbomer mentioned this pull request Aug 17, 2022
Merged
@MichalStrehovsky
Copy link
Member

I suggest we take Sven's #74046 (backport in #74048) instead.

@MichalStrehovsky MichalStrehovsky added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 17, 2022
@lewing lewing closed this Aug 17, 2022
@akoeplinger akoeplinger deleted the revert-73416-CleanPublishAot branch August 18, 2022 15:34
@ghost ghost locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LakshanF LakshanF LakshanF approved these changes

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky MichalStrehovsky is a code owner

@sbomer sbomer Awaiting requested review from sbomer

Assignees

@lewing lewing

Labels
area-NativeAOT-coreclr NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lewing @MichalStrehovsky @LakshanF @jeffschwMSFT