Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move v1 marshaller design to Ancillary.Interop #71980

Closed
wants to merge 1 commit into from
Closed

Move v1 marshaller design to Ancillary.Interop #71980

wants to merge 1 commit into from

Conversation

jkoritzinsky
Copy link
Member

Move the v1 attributes out of the ref assemblies as we don't need to ship them anymore and we'd like to reduce confusion around having both systems exposed.

Depends on #71978

Contributes to #70859

@jkoritzinsky jkoritzinsky added area-System.Runtime.InteropServices blocked Issue/PR is blocked on something - see comments source-generator Indicates an issue with a source generator feature labels Jul 11, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned jkoritzinsky Jul 11, 2022
@ghost
Copy link

ghost commented Jul 11, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

Move the v1 attributes out of the ref assemblies as we don't need to ship them anymore and we'd like to reduce confusion around having both systems exposed.

Depends on #71978

Contributes to #70859

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, blocked, source-generator
Milestone: -

@jkoritzinsky jkoritzinsky mentioned this pull request Jul 12, 2022
Merged
elinor-fung
elinor-fung approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@elinor-fung elinor-fung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we only keep the enums in Ancillary.Interop and completely CustomTypeMarshallerAttribute?
edit: nevermind, I blanked and forgot you already mentioned moving the not-yet-exposed SpanMarshallers separately

I only looked at the last commit, ignoring the commits from the ArrayMarshaller change.

@jkoritzinsky jkoritzinsky marked this pull request as ready for review July 12, 2022 04:50
@jkoritzinsky jkoritzinsky removed the blocked Issue/PR is blocked on something - see comments label Jul 12, 2022
@runfoapp runfoapp bot mentioned this pull request Jul 12, 2022
Closed
@jkoritzinsky
Copy link
Member Author

Failures are the comhost test infra issue and #71997

@jkoritzinsky
Copy link
Member Author

Replaced by #71989

@jkoritzinsky jkoritzinsky deleted the private-v1-design branch July 12, 2022 23:36
@ghost ghost locked as resolved and limited conversation to collaborators Aug 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@elinor-fung elinor-fung elinor-fung approved these changes

Assignees

@jkoritzinsky jkoritzinsky

Labels
area-System.Runtime.InteropServices new-api-needs-documentation source-generator Indicates an issue with a source generator feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoritzinsky @elinor-fung