Move ArrayMarshaller and PointerArrayMarshaller to the v2 design #71978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the built-in custom array pinning code as we don't need it any more (it's implemented on the marshallers themselves with the static GetPinnableReference method)
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsRemove the built-in custom array pinning code as we don't need it any more (it's implemented on the marshallers themselves with the static GetPinnableReference method)
|
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
jkoritzinsky
force-pushed
the
array-marshaller-v2
branch
2 times, most recently
from
29a2773
to
19c6a7c
Compare
jkoritzinsky
force-pushed
the
array-marshaller-v2
branch
from
19c6a7c
to
cabcc42
Compare
elinor-fung
reviewed
Jul 11, 2022
src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
force-pushed
the
array-marshaller-v2
branch
from
5c5851a
to
72e9f03
Compare
jkoritzinsky
force-pushed
the
array-marshaller-v2
branch
from
039ed3f
to
63b2707
Compare
elinor-fung
reviewed
Jul 11, 2022
...ies/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/ArrayMarshaller.cs
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Jul 12, 2022
…marshallers uncovered.
|
The test failures are #71990 and a GC hole that is under investigation. I'm going to merge this in. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the built-in custom array pinning code as we don't need it any more (it's implemented on the marshallers themselves with the static GetPinnableReference method)
Contributes to #70859