Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.0-rc2] Fix createdump Windows triage dumps #42394

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 17, 2020

Backport of #42159 to release/5.0-rc2

/cc @mikem8361

Customer Impact

Windows triage dumps generated with createdump didn't have all the memory needed to be useful.

Testing

The diagnostics repo SOS/dotnet-dump testing.

Risk

Low risk affects just Windows and Linux createdump.

@ghost
Copy link

ghost commented Sep 17, 2020

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@mikem8361 mikem8361 self-assigned this Sep 17, 2020
@mikem8361 mikem8361 added the Servicing-consider Issue for next servicing release review label Sep 17, 2020
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please get a CR and we should consider it for RC2

@jeffschwMSFT jeffschwMSFT added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 17, 2020
@jeffschwMSFT
Copy link
Member

Approved for RC2 via email

@mikem8361 mikem8361 merged commit 081a7ab into release/5.0-rc2 Sep 17, 2020
@mikem8361 mikem8361 deleted the backport/pr-42159-to-release/5.0-rc2 branch September 17, 2020 23:49
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants