Fix createdump Windows triage dumps #42159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps. This is important to the windbg linux support.
|
Tagging subscribers to this area: @tommcdon |
|
@janvorli ping? |
|
@mikem8361 I am sorry, I've missed this PR. |
|
/backport to release/5.0-rc2 |
|
Started backporting to release/5.0-rc2: https://github.com/dotnet/runtime/actions/runs/259774185 |
mikem8361
added a commit
to mikem8361/runtime
that referenced
this pull request
Sep 22, 2020
The stack unwinding in createdump was looping forever on the same IP (different SP) when it was attempting to unwind a frame that was in the ld module (typically libld*.so or on alpine ld-musl-x86_64.so). The ld module on Alpine doesn't having any unwind info (GNU_EH_FRAME empty) causing the libunwind code to loop on the same IP. This was caused by a recent change in PR dotnet#42159 to createdump that included the ld in the coredump. Createdump wouldn't attempt to unwind IPs in the ld module because it wasn't added to the module lookup list. Including the ld module is important to the windbg linux support so it will have to be revisited in 6.0 by changing the remote unwinder to handle this case of the Alpine ld module.
mikem8361
added a commit
that referenced
this pull request
Sep 22, 2020
The stack unwinding in createdump was looping forever on the same IP (different SP) when it was attempting to unwind a frame that was in the ld module (typically libld*.so or on alpine ld-musl-x86_64.so). The ld module on Alpine doesn't having any unwind info (GNU_EH_FRAME empty) causing the libunwind code to loop on the same IP. This was caused by a recent change in PR #42159 to createdump that included the ld in the coredump. Createdump wouldn't attempt to unwind IPs in the ld module because it wasn't added to the module lookup list. Including the ld module is important to the windbg linux support so it will have to be revisited in 6.0 by changing the remote unwinder to handle this case of the Alpine ld module.
github-actions bot
pushed a commit
that referenced
this pull request
Sep 22, 2020
The stack unwinding in createdump was looping forever on the same IP (different SP) when it was attempting to unwind a frame that was in the ld module (typically libld*.so or on alpine ld-musl-x86_64.so). The ld module on Alpine doesn't having any unwind info (GNU_EH_FRAME empty) causing the libunwind code to loop on the same IP. This was caused by a recent change in PR #42159 to createdump that included the ld in the coredump. Createdump wouldn't attempt to unwind IPs in the ld module because it wasn't added to the module lookup list. Including the ld module is important to the windbg linux support so it will have to be revisited in 6.0 by changing the remote unwinder to handle this case of the Alpine ld module.
mikem8361
added a commit
that referenced
this pull request
Sep 22, 2020
The stack unwinding in createdump was looping forever on the same IP (different SP) when it was attempting to unwind a frame that was in the ld module (typically libld*.so or on alpine ld-musl-x86_64.so). The ld module on Alpine doesn't having any unwind info (GNU_EH_FRAME empty) causing the libunwind code to loop on the same IP. This was caused by a recent change in PR #42159 to createdump that included the ld in the coredump. Createdump wouldn't attempt to unwind IPs in the ld module because it wasn't added to the module lookup list. Including the ld module is important to the windbg linux support so it will have to be revisited in 6.0 by changing the remote unwinder to handle this case of the Alpine ld module. Co-authored-by: Mike McLaughlin <mikem@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ld (i.e. ld_2_23.so) interpreter program headers to Linux coredumps. This is important to the windbg linux support.