Propagate RuntimeConfiguration for cross-subset builds #107049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
needs-area-label
elinor-fung
added
area-Infrastructure
and removed
needs-area-label
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
This was referenced Aug 27, 2024
Co-authored-by: Jeremy Koritzinsky <jkoritzinsky@gmail.com>
jkoritzinsky
approved these changes
Aug 27, 2024
elinor-fung
changed the title
|
/ba-g timeouts in legs unaffected by this change |
jtschuster
pushed a commit
to jtschuster/runtime
that referenced
this pull request
Sep 17, 2024
This addresses issues building cross-subset with clr (or mono) with mixed configurations. For example, `singlefilehost` is built as part of the `clr` subset, but the `host` subset copies it, embeds the DAC (when necessary) and packages it. When the clr and host configuration didn't match, this resulted in the host build looking for `singlefilehost` in the wrong location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issues building cross-subset with clr with mixed configurations.
For example,
singlefilehostis built as part of theclrsubset, but thehostsubset copies it, embeds the DAC (when necessary) and packages it. When the clr and host configuration didn't match, this resulted in the host build looking forsinglefilehostin the wrong location.