Skip to content

Commit

Permalink
Propagate RuntimeConfiguration for cross-subset builds (#107049)
Browse files Browse the repository at this point in the history
This addresses issues building cross-subset with clr (or mono) with mixed configurations.

For example, `singlefilehost` is built as part of the `clr` subset, but the `host` subset copies it, embeds the DAC (when necessary) and packages it. When the clr and host configuration didn't match, this resulted in the host build looking for `singlefilehost` in the wrong location.
  • Loading branch information
elinor-fung committed Aug 28, 2024
1 parent f66ae9c commit 063ae05
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions eng/Subsets.props
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,7 @@
<AdditionalProperties Condition="'%(ProjectToBuild.Category)' == 'tools'">%(AdditionalProperties);Configuration=$(ToolsConfiguration)</AdditionalProperties>

<!-- Propagate configurations for cross-subset builds -->
<AdditionalProperties>%(AdditionalProperties);RuntimeConfiguration=$(RuntimeConfiguration)</AdditionalProperties>
<AdditionalProperties>%(AdditionalProperties);LibrariesConfiguration=$(LibrariesConfiguration)</AdditionalProperties>
<AdditionalProperties>%(AdditionalProperties);HostConfiguration=$(HostConfiguration)</AdditionalProperties>
<AdditionalProperties>%(AdditionalProperties);TasksConfiguration=$(TasksConfiguration)</AdditionalProperties>
Expand Down

0 comments on commit 063ae05

Please sign in to comment.