Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integration tests #64452

Merged
merged 10 commits into from
Oct 3, 2022
Merged

Fix integration tests #64452

merged 10 commits into from
Oct 3, 2022

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Oct 3, 2022 •
edited
Loading

Builds on #64366

Additionally fixes how the active document filename was being gotten. An alternative to #64403

@JoeRobich JoeRobich requested a review from a team as a code owner October 3, 2022 20:36
jasonmalinowski
jasonmalinowski approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signoff implicitly also covers the build change too.

@JoeRobich
Copy link
Member Author

Merging as this improves the world. Need to investigate integration test hang.

@JoeRobich JoeRobich merged commit 5bdcbb9 into main Oct 3, 2022
@ghost ghost added this to the Next milestone Oct 3, 2022
@allisonchou allisonchou mentioned this pull request Oct 11, 2022
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 17.5 P1 Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmalinowski jasonmalinowski jasonmalinowski approved these changes

@davidwengier davidwengier davidwengier approved these changes

@Cosifne Cosifne Cosifne approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure
Projects
None yet
Milestone
17.5 P1
Development

Successfully merging this pull request may close these issues.
5 participants
@JoeRobich @jasonmalinowski @davidwengier @Cosifne @RikkiGibson