Listen to build manager events to know when build is complete #64366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cosifne
reviewed
Sep 29, 2022
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Outdated
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Show resolved
Hide resolved
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Outdated
Show resolved
Hide resolved
JoeRobich
force-pushed
the
dev/jorobich/integration-tests
branch
from
162e09e
to
048cc80
Compare
JoeRobich
commented
Sep 29, 2022
| // The build summary line should be second to last in the output window | ||
| return lines[^2].Extent.GetText(); | ||
| // Find the build summary line | ||
| for (var index = lines.Count - 1; index > 0; index--) |
There was a problem hiding this comment.
Found that this was returning "Elapsed time" instead of the build summary.
src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/SolutionExplorerInProcess.cs
Outdated
Show resolved
Hide resolved
|
@jasonmalinowski This is ready for another review. I believe Shen is taking care of the newly failing integration tests in another PR. |
Merged
jasonmalinowski
approved these changes
Oct 3, 2022
| for (var index = lines.Count - 1; index >= 0; index--) | ||
| { | ||
| var lineText = lines[index].Extent.GetText(); | ||
| if (lineText.StartsWith("========== Build:")) |
There was a problem hiding this comment.
Suggested change
| if (lineText.StartsWith("========== Build:")) | |
| if (lineText.StartsWith("==========")) |
Since that won't depend on localization anymore.
There was a problem hiding this comment.
I agree, but the reality is that every test that uses this method immediately Asserts the returned string equals an English build summary. Probably long term we should capture the success, failed, and canceled values returned by the UpdateSolutionEvents Done and return those instead of the build summary.
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CSharpBuild.BuildProject integration test when running against IntPreview builds of VS.