Merge the new UnitTesting solution crawler into Main #64368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unneeded SolutionCrawler reasons that UnitTesting is not using.
…/RemoteLegacySolutionEventsAggregationService.cs
…/RemoteLegacySolutionEventsAggregationService.cs
…nEvents Merge main to features/solutionEvents
…sWorkspaceEventListener.cs Co-authored-by: Gen Lu <genlu@users.noreply.github.com>
Wait until an analyzer is registered before streaming workspace events over to OOP
…nEvents Merge main to features/solutionEvents
…nEvents Merge main to features/solutionEvents
…nEvents Merge main to features/solutionEvents
Update to use new internal API
…nEvents Merge main to features/solutionEvents
|
@tmat Please review. This is merging all the solution-crawler work done in the feature branch back into main :) |
jmarolf
approved these changes
Oct 4, 2022
…nEvents Merge main to features/solutionEvents
|
@tmat review please :) |
tmat
reviewed
Oct 6, 2022
| private InvocationReasons(ImmutableHashSet<string> reasons) | ||
| => _reasons = reasons; | ||
| public InvocationReasons(ImmutableHashSet<string> reasons) | ||
| => _reasons = reasons ?? ImmutableHashSet<string>.Empty; |
tmat
reviewed
Oct 6, 2022
| @@ -19,8 +19,8 @@ namespace Microsoft.CodeAnalysis.ExternalAccess.UnitTesting.Api | |||
| public static readonly UnitTestingInvocationReasonsWrapper PredefinedSyntaxChanged = new(PredefinedInvocationReasons.SyntaxChanged); | |||
| public static readonly UnitTestingInvocationReasonsWrapper PredefinedProjectConfigurationChanged = new(PredefinedInvocationReasons.ProjectConfigurationChanged); | |||
| public static readonly UnitTestingInvocationReasonsWrapper PredefinedDocumentOpened = new(PredefinedInvocationReasons.DocumentOpened); | |||
| public static readonly UnitTestingInvocationReasonsWrapper PredefinedDocumentRemoved = new(PredefinedInvocationReasons.DocumentRemoved); | |||
| public static readonly UnitTestingInvocationReasonsWrapper PredefinedDocumentClosed = new(PredefinedInvocationReasons.DocumentClosed); | |||
tmat
reviewed
Oct 6, 2022
| bool ShouldReportChanges(SolutionServices services); | ||
|
|
||
| ValueTask OnWorkspaceChangedAsync(WorkspaceChangeEventArgs args, CancellationToken cancellationToken); | ||
| #if false // Not used in unit testing crawling |
tmat
reviewed
Oct 6, 2022
| { | ||
| internal interface INewUnitTestingIncrementalAnalyzerImplementation | ||
| { | ||
| #if false // Not used in unit testing crawling |
ghost
added this to the
|
@shyamnamboodiripad this is now merged. PTAL when you can and see about moving onto this :) LMK if you run into any issues. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.