Wait until an analyzer is registered before streaming workspace events over to OOP #64376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This includes a bunch of unrelated changes, could you please sync the target branch with main? Thanks! |
|
@genlu done! |
CyrusNajmabadi
commented
Sep 30, 2022
...ote/ServiceHub/Services/LegacySolutionEvents/RemoteLegacySolutionEventsAggregationService.cs
Outdated
Show resolved
Hide resolved
…/RemoteLegacySolutionEventsAggregationService.cs
CyrusNajmabadi
commented
Sep 30, 2022
...ote/ServiceHub/Services/LegacySolutionEvents/RemoteLegacySolutionEventsAggregationService.cs
Outdated
Show resolved
Hide resolved
…/RemoteLegacySolutionEventsAggregationService.cs
|
@genlu ptal. thanks! |
genlu
reviewed
Sep 30, 2022
src/EditorFeatures/Core/SolutionEvents/HostLegacySolutionEventsWorkspaceEventListener.cs
Outdated
Show resolved
Hide resolved
…sWorkspaceEventListener.cs Co-authored-by: Gen Lu <genlu@users.noreply.github.com>
genlu
approved these changes
Sep 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we're not wasting tons of cpu/memory syncing data to oop that isn't even needed when TestExplorer isn't even visible.