Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support adding new assembly level attributes with SyntaxGenerator when some already exist in the document #60425

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Support adding new assembly level attributes with SyntaxGenerator when some already exist in the document #60425

merged 1 commit into from
Mar 29, 2022

Conversation

jkoritzinsky
Copy link
Member

Fixes #60399

@jkoritzinsky jkoritzinsky requested a review from a team as a code owner March 28, 2022 20:39
@CyrusNajmabadi
Copy link
Member

Thanks!

@jkoritzinsky
Copy link
Member Author

Test failure is #57423. Can we manually merge this in, or do we need to wait for the test to get fixed?

@CyrusNajmabadi CyrusNajmabadi merged commit 496bf63 into dotnet:main Mar 29, 2022
@ghost ghost added this to the Next milestone Mar 29, 2022
@runfoapp runfoapp bot mentioned this pull request Mar 29, 2022
Closed
@jinujoseph jinujoseph added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Mar 30, 2022
@dibarbet dibarbet modified the milestones: Next, 17.3.P1 Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
17.3.P1
4 participants
@jkoritzinsky @CyrusNajmabadi @dibarbet @jinujoseph