Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky integration tests] IDE version '17.2.32314.265' unexpectedly dismissed the light bulb. #60461

Closed
allisonchou opened this issue Mar 29, 2022 · 3 comments · Fixed by #60458
Closed

[Flaky integration tests] IDE version '17.2.32314.265' unexpectedly dismissed the light bulb. #60461

allisonchou opened this issue Mar 29, 2022 · 3 comments · Fixed by #60458
Labels
Area-Infrastructure Flaky Infraswat Integration-Test Test failures in roslyn-integration-CI Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented

Comments

@allisonchou
Copy link
Contributor

allisonchou commented Mar 29, 2022 •
edited by runfoapp bot
Loading

Example failing build: https://dev.azure.com/dnceng/public/_build/results?buildId=1687571&view=results

Failures seen in:

  • Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpUpdateProjectToAllowUnsafe.LegacyProject_AllConfigurationsUpdated
  • Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpCodeActions.FastDoubleInvoke
  • Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpCodeActions.ClassificationInPreviewPane
  • Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpCodeActions.GFUFuzzyMatchAfterRenameTrackingAndAfterGenerateType
  • Roslyn.VisualStudio.NewIntegrationTests.CSharp.CSharpCodeActions.FixAllOccurrencesIgnoresGeneratedCode (this one can't be skipped since it's marked as a critical test)

Message:

"IDE version '17.2.32314.265' unexpectedly dismissed the light bulb."

Runfo Tracking Issue: [Roslyn] IDE version '17.2.32314.265' unexpectedly dismissed the light bulb.

Build Definition Kind Run Name
1689551 roslyn-integration-CI PR 60471 1-Integration Debug OOP64_true OOPCoreClr_false
1689147 roslyn-integration-CI PR 60466 1-Integration Debug OOP64_true OOPCoreClr_false
1688866 roslyn-integration-CI PR 60095 1-Integration Debug OOP64_true OOPCoreClr_false
1688605 roslyn-integration-CI PR 60462 1-Integration Debug OOP64_true OOPCoreClr_false
1688550 roslyn-integration-CI PR 60452 1-Integration Debug OOP64_true OOPCoreClr_false
1688428 roslyn-integration-CI PR 60431 1-Integration Debug OOP64_true OOPCoreClr_false
1688421 roslyn-integration-CI PR 60429 1-Integration Release OOP64_false OOPCoreClr_false
1687963 roslyn-integration-CI PR 60338 1-Integration Debug OOP64_true OOPCoreClr_false
1687960 roslyn-integration-CI PR 60297 1-Integration Debug OOP64_true OOPCoreClr_false
1687585 roslyn-integration-CI PR 60452 2-Integration Release OOP64_false OOPCoreClr_false
1687571 roslyn-integration-CI Rolling 1-Integration Release OOP64_true OOPCoreClr_false
1687482 roslyn-integration-CI PR 60450 1-Integration Debug OOP64_true OOPCoreClr_false
1687391 roslyn-integration-CI PR 60440 2-Integration Debug OOP64_true OOPCoreClr_false
1687213 roslyn-integration-CI PR 60225 1-Integration Debug OOP64_true OOPCoreClr_false
1687213 roslyn-integration-CI PR 60225 1-Integration Release OOP64_false OOPCoreClr_false
1687110 roslyn-integration-CI Rolling 1-Integration Debug OOP64_true OOPCoreClr_false
1687036 roslyn-integration-CI Rolling 1-Integration Release OOP64_true OOPCoreClr_false
1686839 roslyn-integration-CI Rolling 1-Integration Debug OOP64_false OOPCoreClr_false
1686479 roslyn-integration-CI PR 60425 2-Integration Release OOP64_false OOPCoreClr_false
1686253 roslyn-integration-CI PR 60357 1-Integration Debug OOP64_true OOPCoreClr_false
1686228 roslyn-integration-CI Rolling 1-Integration Debug OOP64_true OOPCoreClr_false
1684942 roslyn-integration-CI PR 60321 1-Integration Release OOP64_false OOPCoreClr_false
1684938 roslyn-integration-CI Rolling 1-Integration Debug OOP64_false OOPCoreClr_false
1684897 roslyn-integration-CI Rolling 1-Integration Debug OOP64_true OOPCoreClr_false
1684588 roslyn-integration-CI Rolling 1-Integration Release OOP64_true OOPCoreClr_false
1684122 roslyn-integration-CI PR 60405 1-Integration Debug OOP64_true OOPCoreClr_false
1683963 roslyn-integration-CI PR 60405 1-Integration Release OOP64_false OOPCoreClr_false
1683923 roslyn-integration-CI PR 60404 1-Integration Debug OOP64_true OOPCoreClr_false
1683631 roslyn-integration-CI PR 60401 1-Integration Release OOP64_false OOPCoreClr_false
1683147 roslyn-integration-CI Rolling 1-Integration Debug OOP64_true OOPCoreClr_false

Build Result Summary

Day Hit Count Week Hit Count Month Hit Count
5 29 29
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Issues and PRs which have not yet been triaged by a lead label Mar 29, 2022
This was referenced Mar 29, 2022
Closed
Merged
@sharwell
Copy link
Member

This error occurs because the light bulb is still showing errors in the current CI version. When this happens, we need to let the editor team know that the light bulb is broken and update the workaround here:

roslyn/src/VisualStudio/IntegrationTest/New.IntegrationTests/InProcess/LightBulbHelper.cs

Lines 91 to 95 in dcfd613

if (Version.Parse("17.2.32210.308") >= version)
{
// Unexpected cancellation can occur when the editor dismisses the light bulb without request
return null;
}

sharwell added a commit to sharwell/roslyn that referenced this issue Mar 29, 2022
@sharwell
Update light bulb workaround version
4188775 
Closes dotnet#60461
sharwell added a commit to sharwell/roslyn that referenced this issue Mar 29, 2022
@sharwell
Update light bulb workaround version
71449b6 
Closes dotnet#60461
@sharwell sharwell mentioned this issue Mar 30, 2022
Merged
@sharwell sharwell added Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 30, 2022
@JoeRobich
Copy link
Member

JoeRobich commented Mar 31, 2022 •
edited
Loading

This is failing in our nightly VS main branch run of integration tests - https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=5963150&view=results (microsoft)

@sharwell
Copy link
Member

sharwell commented Mar 31, 2022 •
edited by Pilchie
Loading

@JoeRobich That issue is tracked internally: AB#1511117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Infrastructure Flaky Infraswat Integration-Test Test failures in roslyn-integration-CI Resolution-Fixed The bug has been fixed and/or the requested behavior has been implemented
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable CSharpGoToBase.GoToBaseFromMetadataAsSource sharwell/roslyn
3 participants
@JoeRobich @sharwell @allisonchou