Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic benchmark for returning text edits in LSP completion #60239

Merged
merged 2 commits into from
Mar 17, 2022

Conversation

dibarbet
Copy link
Member

@dibarbet dibarbet commented Mar 17, 2022

In preparation for the fix for #59773 to allow us to specify item defaults, added a benchmark to compare the current performance of the textedits feature flag. Note this includes serialization.

These will need to be updated once the new client packages are ready and we can respond to them, but this just shows the current difference.
Release mode

Method Mean Error StdDev Gen 0 Gen 1 Gen 2 Allocated
GetCompletionsWithTextEdits 138.93 ms 2.427 ms 2.493 ms 2000.0000 2000.0000 - 16 MB
GetCompletionsWithoutTextEdits 79.11 ms 1.510 ms 1.338 ms 1000.0000 1000.0000 - 9 MB

@dibarbet dibarbet marked this pull request as ready for review March 17, 2022 19:40
@dibarbet dibarbet requested review from a team as code owners March 17, 2022 19:40
Copy link
Contributor

@NTaylorMullen NTaylorMullen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the prep!

@dibarbet dibarbet enabled auto-merge (squash) March 17, 2022 20:26
@dibarbet dibarbet merged commit ce2c2db into dotnet:main Mar 17, 2022
@ghost ghost added this to the Next milestone Mar 17, 2022
@allisonchou allisonchou modified the milestones: Next, 17.2.P3 Mar 28, 2022
@dibarbet dibarbet deleted the benchmark_textedit_completion branch March 29, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants