Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LSP] Doc comment completions do not auto-insert attribute content #59773

Closed
NTaylorMullen opened this issue Feb 25, 2022 · 4 comments · Fixed by #60466
Closed

[LSP] Doc comment completions do not auto-insert attribute content #59773

NTaylorMullen opened this issue Feb 25, 2022 · 4 comments · Fixed by #60466
Assignees
@dibarbet
Labels
Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it LSP issues related to the roslyn language server protocol implementation

Comments

@NTaylorMullen
Copy link
Contributor

NTaylorMullen commented Feb 25, 2022 •
edited
Loading

Version Used: 17.2-Preview1 (VSMain)

Originally mentioned by customer in: https://developercommunity.visualstudio.com/t/Blazor-documentation-editing-is-broken/1654897

Steps to Reproduce:

  1. Enable C# LSP editor
  2. In a doc comment try invoking the <see completion item

Expected Behavior:
Inserts <see cref="|"/> where cursor is at |
devenv_cgP0iZFIur

Actual Behavior:
Just inserts <see
devenv_ulo2t6frwx
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Feb 25, 2022
@jinujoseph jinujoseph added Bug LSP issues related to the roslyn language server protocol implementation and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Mar 2, 2022
@jinujoseph jinujoseph added this to the 17.2 milestone Mar 2, 2022
@jinujoseph jinujoseph added the help wanted The issue is "up for grabs" - add a comment if you are interested in working on it label Mar 2, 2022
@jinujoseph jinujoseph assigned dibarbet and unassigned davidwengier Mar 2, 2022
@dibarbet
Copy link
Member

dibarbet commented Mar 2, 2022

We need to support text edits from completion, with @allisonchou flag on this mostly works, though we need to fix the caret position.

I remember this was blocked on dotnet/razor#4408 per #59545 (comment)
completion_textedits

@NTaylorMullen I see the lsp spec change is merged, I guess we only need the vs client implementation?

@dibarbet
Copy link
Member

dibarbet commented Mar 2, 2022

Same underlying issue as #59545

@NTaylorMullen
Copy link
Contributor Author

@NTaylorMullen I see the lsp spec change is merged, I guess we only need the vs client implementation?

Ya I believe so

This was referenced Mar 8, 2022
Closed
Open
@dibarbet
Copy link
Member

Quick update - client change is merged, https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/385049 once that flows through will look at supporting the C# and Razor implementation.

This was referenced Mar 14, 2022
Closed
Merged
@dibarbet dibarbet mentioned this issue Mar 29, 2022
Merged
@janseris janseris mentioned this issue Sep 3, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibarbet dibarbet

Labels
Area-IDE Bug help wanted The issue is "up for grabs" - add a comment if you are interested in working on it LSP issues related to the roslyn language server protocol implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always use text edits in completion for correctness dibarbet/roslyn
4 participants
@davidwengier @NTaylorMullen @dibarbet @jinujoseph