Revert "[release/8.0] Stabilize package versions for .NET 8" #7003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e640355.
mmitche
approved these changes
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## release/8.0.1xx #7003 +/- ##
===================================================
- Coverage 96.39% 96.39% -0.01%
===================================================
Files 1402 1402
Lines 332264 332264
Branches 11065 11065
===================================================
- Hits 320291 320274 -17
- Misses 8894 8907 +13
- Partials 3079 3083 +4 |
Kritner
pushed a commit
to Kritner/roslyn-analyzers
that referenced
this pull request
Apr 11, 2024
This reverts commit e640355.
buyaa-n
pushed a commit
that referenced
this pull request
Aug 23, 2024
…templates) (#7286) * Stabilize package versions (#7002) * Revert "Stabilize package versions (#7002)" (#7003) This reverts commit e640355. * Adds validation against invalid bracket pairs * Fixes #7285 * Fix extra break flagged by CI * Remove one branch to be fully covered * Adds secondary occurrence of CA2017 around mismatched braces * Adds new messages to base resource file * Ran resource generation * Fix tests, use `WorkItem` attribute * documentation updates for CA2017 * Revert "documentation updates for CA2017" This reverts commit 4c41c4e. * Trying something else with CA2017 regarding localization * Needed to have a title and description that match *both* potential reasons for this warning * The individual messages for the differing reasons is still separate, but the MD/sarif description seemed to be "last wins" when it comes to a title/description * The `msbuild /t:pack` command kept failing for me, so upped the global.json to target a non preview .net8 SDK, but am not checking that change in * Finish rebase * Take into account escaped braces * Use CA2023 instead of an overloaded CA2017 * Revert "Ran resource generation" This reverts commit 26f1e68. * Revert "Adds new messages to base resource file" This reverts commit 386fe96. * Adds new CA2023 information to resources * Will likely need a follow up commit to "undo" the "new" tags around `CA2017`, as these should now match from main * Reverts "new" translation indicators back to their previously "translated" versions from CA2017 * CA2017 was originally repurposed, which caused undesired impacts to already released versions of the analyzer. Instead these changes are introduced as a new CA2023 #7286 (comment) * Missed a few files from last commit * More covering tests, comment tweaking * Remove additional space between sentences, `error` -> `warning` * fix(LoggerMessageDefineAnalyzer): BuildError -> BuildWarning * Optimized impl from @tarekgh * linting and another missed `error` -> `warning` * Additional covering tests --------- Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7002
Stabilizing packages in roslyn-analyzers isn't required for the .NET 8 release.