Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Stabilize package versions for .NET 8 #7002

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

ViktorHofer
Copy link
Member

No description provided.

@ViktorHofer ViktorHofer requested a review from a team as a code owner October 25, 2023 11:17
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #7002 (1d61e0b) into release/8.0.1xx (4ff2809) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##           release/8.0.1xx    #7002      +/-   ##
===================================================
- Coverage            96.39%   96.39%   -0.01%     
===================================================
  Files                 1402     1402              
  Lines               332264   332264              
  Branches             11065    11065              
===================================================
- Hits                320282   320274       -8     
+ Misses                9209     8907     -302     
- Partials              2773     3083     +310     

@ViktorHofer ViktorHofer changed the title Stabilize package versions for .NET 8 [release/8.0] Stabilize package versions for .NET 8 Oct 25, 2023
@jjonescz jjonescz merged commit e640355 into dotnet:release/8.0.1xx Oct 25, 2023
14 checks passed
@ViktorHofer ViktorHofer deleted the patch-1 branch October 25, 2023 11:49
ViktorHofer added a commit to ViktorHofer/roslyn-analyzers that referenced this pull request Oct 25, 2023
mmitche pushed a commit that referenced this pull request Oct 25, 2023
Kritner pushed a commit to Kritner/roslyn-analyzers that referenced this pull request Apr 11, 2024
Kritner pushed a commit to Kritner/roslyn-analyzers that referenced this pull request Apr 11, 2024
buyaa-n pushed a commit that referenced this pull request Aug 23, 2024
…templates) (#7286)

* Stabilize package versions (#7002)

* Revert "Stabilize package versions (#7002)" (#7003)

This reverts commit e640355.

* Adds validation against invalid bracket pairs
* Fixes #7285

* Fix extra break flagged by CI

* Remove one branch to be fully covered

* Adds secondary occurrence of CA2017 around mismatched braces

* Adds new messages to base resource file

* Ran resource generation

* Fix tests, use `WorkItem` attribute

* documentation updates for CA2017

* Revert "documentation updates for CA2017"

This reverts commit 4c41c4e.

* Trying something else with CA2017 regarding localization
* Needed to have a title and description that match *both* potential reasons for this warning
* The individual messages for the differing reasons is still separate, but the MD/sarif description seemed to be "last wins" when it comes to a title/description
* The `msbuild /t:pack` command kept failing for me, so upped the global.json to target a non preview .net8 SDK, but am not checking that change in

* Finish rebase

* Take into account escaped braces

* Use CA2023 instead of an overloaded CA2017

* Revert "Ran resource generation"

This reverts commit 26f1e68.

* Revert "Adds new messages to base resource file"

This reverts commit 386fe96.

* Adds new CA2023 information to resources
* Will likely need a follow up commit to "undo" the "new" tags around `CA2017`, as these should now match from main

* Reverts "new" translation indicators back to their previously "translated" versions from CA2017
* CA2017 was originally repurposed, which caused undesired impacts to already released versions of the analyzer. Instead these changes are introduced as a new CA2023 #7286 (comment)

* Missed a few files from last commit

* More covering tests, comment tweaking

* Remove additional space between sentences, `error` -> `warning`

* fix(LoggerMessageDefineAnalyzer): BuildError -> BuildWarning

* Optimized impl from @tarekgh

* linting and another missed `error` -> `warning`

* Additional covering tests

---------

Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants