-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a runtime check for Microsoft.IO.Redist #7335
Comments
@AR-May, does this sound like something that you could do? |
|
@teo-tsirpanis We have many releases of MSBuild in our future that will run on .NET Framework in Visual Studio, which has only recently adopted #7258 does not represent a commitment to move off .NET Framework; it's more work along the lines of #7257 to create a more capable and unified MSBuild deployment scenario. We clarified that by editing the issue. |
You have not, as we haven't made it yet. We have tried to find users of it (dotnet/runtime#54919 (comment)), but we did not find any. Since it was increasing the complexity (#if defs for .NET and .NET Framework) and maintenance (the logic had to be tested for both runtimes) we decided to stop shipping it. It means that we won't be adding new APIs to it, but if you hit a bug in the version that we have shipped with .NET 6, we are (most likely) going to fix it. cc @jeffhandley |
Microsoft.IO.Redist requires using a windows library, so it doesn't work on linux/mac. Users using framework on either of those platforms get exceptions. Fixes #7335.
Since #6771 merged, the net472 build uses Microsoft.IO.Redist (M.IO.R) instead of System.IO. This is a problem when running the net472 build on Linux or MacOS, since M.IO.R pinvokes into Kernel32 which is a Windows library.
It would be good to have a runtime check and fallback to System.IO on non-windows platforms.
The text was updated successfully, but these errors were encountered: