Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates included build tool to match the current 6.0.200 sdk #2329

Merged
merged 8 commits into from
Jan 25, 2022

Conversation

JoeRobich
Copy link
Member

Includes the changes to completion and block structure options from #2306

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@filipw
Copy link
Member

filipw commented Jan 24, 2022

Microsoft.Build.Exceptions.InvalidProjectFileException: The imported project "C:\Users\runneradmin\AppData\Local\Temp\541ofin3.s03\ProjectWithAnalyzers\obj\ProjectWithAnalyzers.csproj..props" was not found. Confirm that the expression in the Import declaration "C:\Users\runneradmin\AppData\Local\Temp\541ofin3.s03\ProjectWithAnalyzers\obj\ProjectWithAnalyzers.csproj..props" is correct, and that the file exists on disk. D:\a\omnisharp-roslyn\omnisharp-roslyn.msbuild\Current\Microsoft.Common.props

is this *.props some new MSBuild feature? I find it hard to comprehend what fails here

System.BadImageFormatException: Could not resolve field token 0x0400110f, due to: Could not load type of field 'Microsoft.Build.Shared.FileSystem.ManagedFileSystem+<>c:<>9__10_0' (1) due to: Could not load file or assembly 'Microsoft.IO.Redist, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51' or one of its dependencies. assembly:/Users/runner/work/omnisharp-roslyn/omnisharp-roslyn/bin/Release/OmniSharp.MSBuild.Tests/net472/Microsoft.Build.dll type:<>c member:(null)

Looks like on Unix we need to include Microsoft.IO.Redist in the local msbuild?


// This issue only affects the MSBuild tools shipped with O# as Mono does not ship
// with a version of MSBuild that includes this change.
Environment.SetEnvironmentVariable("MSBUILDDISABLEFEATURESFROMVERSION", "17.0");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is some dark magic man

I think we need to expedite getting rid of the standalone msbuild feature as we discussed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I opened an issue and it should get resolved for 17.2 (dotnet/msbuild#7335), but not shipping is best path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants