Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MauiUIApplicationDelegate.PerformFetch #7982

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Add MauiUIApplicationDelegate.PerformFetch #7982

merged 3 commits into from
Mar 7, 2023

Conversation

jfversluis
Copy link
Member

Description of Change

Seems like we didn't add the MauiUIApplicationDelegate.PerformFetch as a virtual to override.

Issues Fixed

Fixes #7957

@jfversluis jfversluis added this to the .NET 7 milestone Jun 13, 2022
@jfversluis
Copy link
Member Author

@mattleibow not sure if you're the right person but saw some recent changes from you here. Is this the right way to go about this? And I guess this should target the net7 branch?

@mattleibow
Copy link
Member

Main is correct as it is pseudo net7.

But for this, could we also add delegates for the life cycle events? This way, users do not have to override in order to hook in to it.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Jun 21, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@edgiardina
Copy link

Just voting for the LifeCycleEvents approach.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jfversluis jfversluis removed this from the .NET 7 + Servicing milestone Mar 2, 2023
@jfversluis jfversluis marked this pull request as ready for review March 2, 2023 14:57
@jfversluis
Copy link
Member Author

@mattleibow it's been a while! But finally got to update this one, so it you please...

@edgiardina
Copy link

edgiardina commented Mar 2, 2023

Love that the delegates are there. I ended up implementing Shiny.NET Jobs in their prerelease MAUI packages as a workaround, which offered a crossplatform way to implement backgrounding.
https://shinylib.net/mobile/jobs/index.html?tabs=ios

But exposing the iOS via the delegates is awesome too. Thank you.

@jfversluis jfversluis merged commit 8b55253 into main Mar 7, 2023
@jfversluis jfversluis deleted the fix-7957 branch March 7, 2023 06:15
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS AppDelegate - Override for PerformFetch is not available
6 participants