Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PerformFetch iOS lifecycle delegate lacking an extension method #17960

Open
davidbritch opened this issue Oct 11, 2023 · 1 comment
Open

PerformFetch iOS lifecycle delegate lacking an extension method #17960

davidbritch opened this issue Oct 11, 2023 · 1 comment
Labels
area-core-lifecycle XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events i/great-reporter This issue is opened by an author who is known to open high-quality issues platform/iOS 🍎 t/bug Something isn't working
Milestone

Comments

@davidbritch
Copy link
Contributor

Description

This PR adds a PerformFetch override to MauiUIApplicationDelegate, and adds it as an iOS lifecycle delegate.

What it doesn't do is add it as extension method to iOSLifecycleBuilderExtensions. AFAIK, it's the only iOS lifecycle delegate that doesn't have a corresponding extension method.

This means you have to use the AddEvent method to consume PerformFetch, which is a different pattern.

At the same time, PerformFetch is actually deprecated on iOS (see https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623125-application), so maybe no time should be wasted here other than obsoleting it.

Steps to Reproduce

No response

Link to public reproduction project repository

No response

Version with bug

8.0.0-rc.1.9171

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

Unknown/Other

Affected platforms

iOS

Affected platform versions

No response

Did you find any workaround?

Use AddEvent to consume the PerformFetch iOS lifecycle delegate.

Relevant log output

No response

@davidbritch davidbritch added the t/bug Something isn't working label Oct 11, 2023
@ghost ghost added the i/great-reporter This issue is opened by an author who is known to open high-quality issues label Oct 11, 2023
@mattleibow
Copy link
Member

Related, I always see this in the logs:

2023-10-13 08:41:38.800 TapGestureIssue[69624:2609915] You've implemented -[ application:performFetchWithCompletionHandler:], but you still need to add "fetch" to the list of your supported UIBackgroundModes in your Info.plist.

We probably need to override RespondsToSelector and do a check to return false - but that may be iffy.

@PureWeen PureWeen added the area-core-lifecycle XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events label May 31, 2024
@jsuarezruiz jsuarezruiz added this to the Backlog milestone Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-lifecycle XPlat and Native UIApplicationDelegate/Activity/Window lifecycle events i/great-reporter This issue is opened by an author who is known to open high-quality issues platform/iOS 🍎 t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants