RadioButton Default Template Fill Theme Fix and new Theme Colors for Samples app #14117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onary. Added Light/Dark theme colors for RadioButton components to AppResources of sample app to visually demonstrate
dustin-wojciechowski
added
the
area-controls-radiobutton
ghost
added
the
legacy-area-controls
jfversluis
reviewed
Mar 22, 2023
jfversluis
approved these changes
Mar 22, 2023
jsuarezruiz
approved these changes
Mar 22, 2023
jfversluis
approved these changes
Mar 28, 2023
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixed issue where fill property was not populating from ResourceDictionary.
Added Light/Dark theme colors for RadioButton components to AppResources of sample app to visually demonstrate. (These were the default before, Black for Light and White for Dark modes.)
For the Samples app, I've chosen the previously chosen accent colors:
