RadioButton Default Template Fill Theme Fix and new Theme Colors for …

…Samples app (#14117)

* Fixed issue where fill property was not populating from ResourceDictionary. Added Light/Dark theme colors for RadioButton components to AppResources of sample app to visually demonstrate

* Removed old RadioButtonThemeColors from AppResources of Sample gallery

src/Controls/samples/Controls.Sample/AppResources.xaml

@@ -27,6 +27,14 @@
     <Color x:Key="DarkTextSecondaryColor">#f5f5f5</Color>
     <Color x:Key="DarkBorderColor">#fefefe</Color>
 
+    <!--Individual Dark/Light Theme colors for RadioButton Components -->
+    <SolidColorBrush x:Key="RadioButtonOuterEllipseStrokeLight">#5639b0</SolidColorBrush>
+    <SolidColorBrush x:Key="RadioButtonOuterEllipseStrokeDark">#7e2bea</SolidColorBrush>
+    <SolidColorBrush x:Key="RadioButtonCheckGlyphStrokeLight">#5639b0</SolidColorBrush>
+    <SolidColorBrush x:Key="RadioButtonCheckGlyphStrokeDark">#7e2bea</SolidColorBrush>
+    <SolidColorBrush x:Key="RadioButtonCheckGlyphFillLight">#5639b0</SolidColorBrush>
+    <SolidColorBrush x:Key="RadioButtonCheckGlyphFillDark">#7e2bea</SolidColorBrush>
+
     <!-- STYLES -->
     <Style x:Key="SearchBorderStyle" TargetType="Frame">
         <Setter Property="BackgroundColor" Value="{AppThemeBinding Light={StaticResource LightBackgroundSecondaryColor}, Dark={StaticResource DarkBackgroundSecondaryColor}}" />

src/Controls/src/Core/RadioButton.cs

@@ -526,6 +526,8 @@ static View BuildDefaultTemplate()
 			object outerEllipseVisualStateDark = null;
 			object checkMarkVisualStateLight = null;
 			object checkMarkVisualStateDark = null;
+			object checkMarkFillVisualStateLight = null;
+			object checkMarkFillVisualStateDark = null;
 
 			if (!normalEllipse.TrySetDynamicThemeColor(
 				RadioButtonThemeColor,
@@ -568,8 +570,8 @@ static View BuildDefaultTemplate()
 					Ellipse.FillProperty,
 					SolidColorBrush.White,
 					SolidColorBrush.Black,
-					out _,
-					out _);
+					out checkMarkFillVisualStateLight,
+					out checkMarkFillVisualStateDark);
 			}
 
 			contentPresenter.SetBinding(MarginProperty, new Binding("Padding", source: RelativeBindingSource.TemplatedParent));
@@ -620,7 +622,7 @@ static View BuildDefaultTemplate()
 				{
 					Property = Shape.FillProperty,
 					TargetName = CheckedIndicator,
-					Value = dynamicCheckMarkThemeColor is not null ? dynamicCheckMarkThemeColor : new AppThemeBinding() { Light = checkMarkVisualStateLight, Dark = checkMarkVisualStateDark }
+					Value = dynamicCheckMarkThemeColor is not null ? dynamicCheckMarkThemeColor : new AppThemeBinding() { Light = checkMarkFillVisualStateLight, Dark = checkMarkFillVisualStateDark }
 				});
 			checkedStates.States.Add(checkedVisualState);