Reenable ViewTransform unit tests for iOS #13642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
platform/iOS 🍎
t/housekeeping ♻︎
area-testing
mandel-macaque
approved these changes
Mar 2, 2023
jfversluis
commented
Mar 9, 2023
Comment on lines
-40
to
-43
| var superLayer = layer.SuperLayer; | ||
| if (layer.Transform.IsIdentity && superLayer == null) | ||
| return new Matrix4x4(); | ||
|
|
There was a problem hiding this comment.
This does fix the test and I don't see any visual change in the working of the transformations on iOS.
From what I gather on the line below we're already checking if the SuperLayer is null and else just take the identity matrix and apply the transform to whichever one comes out of that null coalescing?
But happy to have a more experts opinion here. I see @drasticactions did something around this area in #5206
hartez
approved these changes
Mar 29, 2023
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Reenables the transform unit tests for iOS which were unable to run before because of #3600
Issues Fixed
Fixes #13429