Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into live #41528

Merged
merged 6 commits into from
Jun 22, 2024
Merged

Merge main into live #41528

merged 6 commits into from
Jun 22, 2024

Conversation

gewarren and others added 6 commits June 21, 2024 10:03
* Add Main declarations

* Replace signature by declaration

* Access modifier rule

* Improve main overview

* Rework Task boilerplate code part

* Fix example

* Update main-command-line.md

* Remove indication about application isn't Library or Service

* fix spellcheck

Co-authored-by: Rich Lander <rlander@microsoft.com>

* Reverse column order in table

* Rever column order that show Main declaration

* fix missing empty line

* Apply suggestions from code review

Co-authored-by: David Pine <david.pine@microsoft.com>

* Specify 'any' explictit access modifier

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>

* Remove boilerplate part

* Add info about completed task

* Fix link

* Remove trailing space

* Fix link

* Fix link

* Fix link

* Fix link

* Reset boilerplate

* Main can be internal

* Rework Main access modifier part

---------

Co-authored-by: Rich Lander <rlander@microsoft.com>
Co-authored-by: David Pine <david.pine@microsoft.com>
Co-authored-by: Bill Wagner <wiwagn@microsoft.com>
From anonymous feedback:

> This article should state that C# and .NET common coding conventions are not "Code Standards" and should not be treated as such.  Code standards would be ANSI, ECMA, ISO, standardized.The common .NET conventions work well for a broad extensive library of .NET API BCL calls but do not scale for a large complex business application.  The conventions work against aligning the code with the business processes by emphasizing deconstructing the C# code into a large complex web of short classes and method.Code should encapsulate business logic and algorithms.

Rather than address the purpose of different rulesets, I replaced all uses of "standard" with "convention". That reinforces that these are our conventions and any customer team should define their own. Their conventions may choose to use ours as a starting point, but shouldn't feel obligated to do so.
The introduction implies that Java allows `struct` types. It does not.

Fixes anonymous feedback.
Prompt engineering edits

---------

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@dotnet-bot dotnet-bot added this to the June 2024 milestone Jun 22, 2024
@dotnet-policy-service dotnet-policy-service bot merged commit 32af537 into live Jun 22, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants