New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix misleading in the Main doc about async/Task #41356

Merged

BillWagner merged 26 commits into dotnet:main from vernou:40972-async-main

Jun 21, 2024

Contributor

vernou commented Jun 10, 2024 •

edited by github-actions bot

Loading

Summary

Modify the overview list to be more explicit
Replace "signature" by "declaration"
Replace "valid Main:" by "the most common Main", because the list isn't exhaustive
Replace "public accessor modifier. That's typical, but not required." by default accessor, because it sound most common
Rework the async/task part

Fixes #40972

Internal previews

📄 File	🔗 Preview link
docs/csharp/fundamentals/program-structure/main-command-line.md	Main() and command-line arguments

vernou added 7 commits

May 19, 2024 12:31


          Add Main declarations

dfb3838


          Replace signature by declaration

32c23d5


          Access modifier rule

056b426


          Improve main overview

2e627d5


          Rework Task boilerplate code part

88610d0


          Fix example

b11de76


          Update main-command-line.md

62053d8

vernou requested a review from BillWagner as a code owner

June 10, 2024 21:30

dotnet-bot added this to the June 2024 milestone

dotnet-bot added dotnet-csharp/svc fundamentals/subsvc labels

dotnet-policy-service bot added the community-contribution label

richlander reviewed

View reviewed changes

docs/csharp/fundamentals/program-structure/main-command-line.md Show resolved Hide resolved

richlander reviewed

View reviewed changes

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

richlander reviewed

View reviewed changes

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

richlander reviewed

View reviewed changes

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

richlander reviewed

View reviewed changes

docs/csharp/fundamentals/program-structure/main-command-line.md Show resolved Hide resolved

Member

richlander commented Jun 11, 2024

vernou and others added 5 commits

June 11, 2024 13:51


          Remove indication about application isn't Library or Service

90934f6


          fix spellcheck

225163c

Co-authored-by: Rich Lander <rlander@microsoft.com>


          Reverse column order in table

4e24462


          Rever column order that show Main declaration


          fix missing empty line

32c8e47

IEvangelist reviewed

View reviewed changes

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

68b268e

Co-authored-by: David Pine <david.pine@microsoft.com>

BillWagner reviewed

View reviewed changes

Member

BillWagner left a comment

I also added some thoughts on this explanation.

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved


          Specify 'any' explictit access modifier

eec3a8d

Co-authored-by: Bill Wagner <wiwagn@microsoft.com>

Contributor Author

vernou commented Jun 11, 2024

@dotnet-policy-service agree

vernou added 2 commits

June 12, 2024 10:59


          Remove boilerplate part

d69c3a5


          Add info about completed task

384f91b

vernou added 6 commits

June 12, 2024 11:18


          Fix link

991c5ce


          Remove trailing space

2ce0be1


          Fix link

b5a3d76


          Fix link

958c9fd


          Fix link

5cf119b


          Fix link

a79733d

vernou requested a review from gewarren as a code owner

June 12, 2024 22:14

vernou and others added 2 commits

June 17, 2024 19:28


          Merge branch 'dotnet:main' into 40972-async-main

bae971b


          Reset boilerplate

vernou mentioned this pull request

"Main()" documentation should not detail hidden implementation from compiler #41457

Open

Contributor Author

vernou commented Jun 17, 2024

This PR was more tricky that anticipated. I prefer to split it and do the asked modification about boilerplate code in another PR.
So I created the issue #41457 to follow up.

vernou requested a review from richlander

June 17, 2024 19:59

richlander approved these changes

View reviewed changes

Member

richlander left a comment

Thanks! I think this is a good set of improvements. We can save the rest for the follow-on PR.

BillWagner requested changes

View reviewed changes

Member

BillWagner left a comment

I agree with Rich that this is a great improvement. Once the one final modification is made, I'll merge it.

docs/csharp/fundamentals/program-structure/main-command-line.md Outdated Show resolved Hide resolved

vernou added 2 commits

June 20, 2024 23:54


          Main can be internal

dd7f7d3


          Rework Main access modifier part

dce4d5c

BillWagner approved these changes

View reviewed changes

BillWagner merged commit 4281f27 into dotnet:main

8 checks passed

vernou deleted the 40972-async-main branch

June 21, 2024 16:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

stephentoub stephentoub left review comments

IEvangelist IEvangelist left review comments

BillWagner BillWagner approved these changes

richlander richlander approved these changes

gewarren Awaiting requested review from gewarren

Labels

community-contribution dotnet-csharp/svc fundamentals/subsvc