Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Use dependency flow for core-setup and corefx dependencies #22544

Merged
merged 5 commits into from
Feb 14, 2019
Merged

Use dependency flow for core-setup and corefx dependencies #22544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f0b036
Remove old use of signing package
hoyosjs Feb 11, 2019
5377276
Move dependency update for CoreFX and Core-setup dependencies to BAR …
hoyosjs Feb 12, 2019
6a0f360
Update property references and bump versions
hoyosjs Feb 12, 2019
120b8a4
Version bump
hoyosjs Feb 12, 2019
78856d9
Update test Github_20958 to use revised System.Range constructor
hoyosjs Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 3 additions & 29 deletions dependencies.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
</RestoreSources>
</PropertyGroup>

<Import Project="eng/Versions.props" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally this would be done from a file like Directory.Build.props, but most of our tests are not SDK projects so it wouldn't get picked up.


<PropertyGroup>
<!-- Central place to set the versions of all nuget packages produced in the repo -->
<PackageVersion Condition="'$(PackageVersion)' == ''">3.0.0</PackageVersion>
Expand All @@ -23,21 +25,16 @@

<!-- Source of truth for dependency tooling: the commit hash of the dotnet/versions master branch as of the last auto-upgrade. -->
<PropertyGroup>
<CoreFxCurrentRef>855b22a229d8730564b19474f9966779b1c4f12b</CoreFxCurrentRef>
<CoreClrCurrentRef>f31086500dc58cefe7b1275300f6fc07b38c1bcc</CoreClrCurrentRef>
<BuildToolsCurrentRef>f31086500dc58cefe7b1275300f6fc07b38c1bcc</BuildToolsCurrentRef>
<PgoDataCurrentRef>7fb04b947ac4fde6e33a57474c5c4a07ef90a185</PgoDataCurrentRef>
<CoreSetupCurrentRef>855b22a229d8730564b19474f9966779b1c4f12b</CoreSetupCurrentRef>
<IbcDataCurrentRef>7fb04b947ac4fde6e33a57474c5c4a07ef90a185</IbcDataCurrentRef>
</PropertyGroup>

<!-- Tests/infrastructure dependency versions. -->
<PropertyGroup>
<MicrosoftPrivateCoreFxNETCoreAppPackageVersion>4.6.0-preview.19106.8</MicrosoftPrivateCoreFxNETCoreAppPackageVersion>
<MicrosoftNETCorePlatformsPackageVersion>3.0.0-preview.19106.8</MicrosoftNETCorePlatformsPackageVersion>
<PgoDataPackageVersion>99.99.99-master-20190130.3</PgoDataPackageVersion>
<MicrosoftNETCoreRuntimeCoreCLRPackageVersion>3.0.0-preview-27316-02</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
<MicrosoftNETCoreAppPackageVersion>3.0.0-preview-27406-8</MicrosoftNETCoreAppPackageVersion>
<XunitPackageVersion>2.4.1</XunitPackageVersion>
<IbcDataPackageVersion>99.99.99-master-20190130.3</IbcDataPackageVersion>
<IbcMergePackageVersion>4.6.0-alpha-00001</IbcMergePackageVersion>
Expand Down Expand Up @@ -77,10 +74,6 @@
</PropertyGroup>

<ItemGroup>
<RemoteDependencyBuildInfo Include="CoreFx">
<BuildInfoPath>$(BaseDotNetBuildInfo)corefx/$(DependencyBranch)</BuildInfoPath>
<CurrentRef>$(CoreFxCurrentRef)</CurrentRef>
</RemoteDependencyBuildInfo>
<RemoteDependencyBuildInfo Include="CoreClr">
<BuildInfoPath>$(BaseDotNetBuildInfo)coreclr/$(DependencyBranch)</BuildInfoPath>
<CurrentRef>$(CoreClrCurrentRef)</CurrentRef>
Expand All @@ -97,35 +90,16 @@
<BuildInfoPath>$(BaseDotNetBuildInfo)optimization/$(DependencyBranch)/IBC</BuildInfoPath>
<CurrentRef>$(IbcDataCurrentRef)</CurrentRef>
</RemoteDependencyBuildInfo>
<RemoteDependencyBuildInfo Include="CoreSetup">
<BuildInfoPath>$(BaseDotNetBuildInfo)core-setup/$(DependencyBranch)</BuildInfoPath>
<CurrentRef>$(CoreSetupCurrentRef)</CurrentRef>
</RemoteDependencyBuildInfo>


<DependencyBuildInfo Include="@(RemoteDependencyBuildInfo)">
<RawVersionsBaseUrl>https://github.com/raw/dotnet/versions</RawVersionsBaseUrl>
</DependencyBuildInfo>

<XmlUpdateStep Include="CoreFx">
<Path>$(MSBuildThisFileFullPath)</Path>
<ElementName>MicrosoftPrivateCoreFxNETCoreAppPackageVersion</ElementName>
<PackageId>Microsoft.Private.CoreFx.NETCoreApp</PackageId>
</XmlUpdateStep>
<XmlUpdateStep Include="CoreFx">
<Path>$(MSBuildThisFileFullPath)</Path>
<ElementName>MicrosoftNETCorePlatformsPackageVersion</ElementName>
<PackageId>Microsoft.NETCore.Platforms</PackageId>
</XmlUpdateStep>
<XmlUpdateStep Include="CoreClr">
<Path>$(MSBuildThisFileFullPath)</Path>
<ElementName>MicrosoftNETCoreRuntimeCoreCLRPackageVersion</ElementName>
<PackageId>Microsoft.NETCore.Runtime.CoreCLR</PackageId>
</XmlUpdateStep>
<XmlUpdateStep Include="CoreSetup">
<Path>$(MSBuildThisFileFullPath)</Path>
<ElementName>MicrosoftNETCoreAppPackageVersion</ElementName>
<PackageId>Microsoft.NETCore.App</PackageId>
</XmlUpdateStep>
<UpdateStep Include="BuildTools">
<UpdaterType>File</UpdaterType>
<Path>$(MSBuildThisFileDirectory)BuildToolsVersion.txt</Path>
Expand Down
12 changes: 12 additions & 0 deletions eng/Version.Details.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,17 @@
<Uri>https://github.com/dotnet/arcade</Uri>
<Sha>14d1133b6074b463784a7adbbf385df0462f4010</Sha>
</Dependency>
<Dependency Name="Microsoft.Private.CoreFx.NETCoreApp" Version="4.6.0-preview.19111.8">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>e8e469653ca46e0499c925dfaaea796fc6f61cb0</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.Platforms" Version="3.0.0-preview.19111.8">
<Uri>https://github.com/dotnet/corefx</Uri>
<Sha>e8e469653ca46e0499c925dfaaea796fc6f61cb0</Sha>
</Dependency>
<Dependency Name="Microsoft.NETCore.App" Version="3.0.0-preview-27411-7">
<Uri>https://github.com/dotnet/core-setup</Uri>
<Sha>70f92292e7302beb9d95933f80421e416bd42ebe</Sha>
</Dependency>
</ToolsetDependencies>
</Dependencies>
19 changes: 7 additions & 12 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,19 +8,14 @@
<UsingToolXliff>false</UsingToolXliff>
<UsingToolNetFrameworkReferenceAssemblies>true</UsingToolNetFrameworkReferenceAssemblies>
<MicrosoftNetFrameworkReferenceAssembliesVersion>1.0.0-alpha-004</MicrosoftNetFrameworkReferenceAssembliesVersion>
<!-- Libs -->
<MicrosoftPrivateCoreFxNETCoreAppVersion>4.6.0-preview.19111.8</MicrosoftPrivateCoreFxNETCoreAppVersion>
<MicrosoftNETCorePlatformsVersion>3.0.0-preview.19111.8</MicrosoftNETCorePlatformsVersion>
<MicrosoftNETCoreAppVersion>3.0.0-preview-27411-7</MicrosoftNETCoreAppVersion>
</PropertyGroup>
<!--Package names-->
<PropertyGroup>
<!-- Override arcade package version to use most recent signing
package -->
<MicrosoftDotNetSignToolVersion>1.0.0-beta.19067.6</MicrosoftDotNetSignToolVersion>
</PropertyGroup>
<PropertyGroup>
<RestoreSources>
$(RestoreSources);
https://dotnetfeed.blob.core.windows.net/dotnet-core/index.json;
https://dotnet.myget.org/F/symreader-converter/api/v3/index.json;
https:%2F%2Fdotnet.myget.org/F/symreader/api/v3/index.json
</RestoreSources>
<MicrosoftPrivateCoreFxNETCoreAppPackage>Microsoft.Private.CoreFx.NETCoreApp</MicrosoftPrivateCoreFxNETCoreAppPackage>
<MicrosoftNETCorePlatformsPackage>Microsoft.NETCore.Platforms</MicrosoftNETCorePlatformsPackage>
<MicrosoftNETCoreAppPackage>Microsoft.NETCore.App</MicrosoftNETCoreAppPackage>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion src/tools/runincontext/runincontext.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<PropertyGroup>
<OutputType>Exe</OutputType>
<TargetFramework>netcoreapp3.0</TargetFramework>
<RuntimeFrameworkVersion>$(MicrosoftNETCoreAppPackageVersion)</RuntimeFrameworkVersion>
<RuntimeFrameworkVersion>$(MicrosoftNETCoreAppVersion)</RuntimeFrameworkVersion>
<UseAppHost>false</UseAppHost>
<CLRTestKind>BuildOnly</CLRTestKind>
</PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion tests/dir.sdkbuild.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<PropertyGroup>
<TargetFramework>netcoreapp3.0</TargetFramework>
<RuntimeFrameworkVersion>$(MicrosoftNETCoreAppPackageVersion)</RuntimeFrameworkVersion>
<RuntimeFrameworkVersion>$(MicrosoftNETCoreAppVersion)</RuntimeFrameworkVersion>
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
<EnableDefaultCompileItems>false</EnableDefaultCompileItems>
<Platform>AnyCPU</Platform>
Expand Down
2 changes: 1 addition & 1 deletion tests/runtest.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ $(_XunitEpilog)
<PropertyGroup>
<OutputPath>$(XUnitTestBinBase)\$(CategoryWithSlash)</OutputPath>
<RuntimeFrameworkVersion>$(MicrosoftNETCoreAppPackageVersion)</RuntimeFrameworkVersion>
<RuntimeFrameworkVersion>$(MicrosoftNETCoreAppVersion)</RuntimeFrameworkVersion>
</PropertyGroup>
<Import Sdk="Microsoft.NET.Sdk" Project="Sdk.props" />
Expand Down
62 changes: 31 additions & 31 deletions tests/src/Common/CoreFX/CoreFX.depproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@
<Version>$(MicrosoftPrivateCoreFxTestUtilitiesPackageVersion)</Version>
</PackageReference>
<PackageReference Include="System.CodeDom">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Configuration.ConfigurationManager">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Composition.Hosting">
<Version>$(SystemCompositionVersions)</Version>
Expand All @@ -79,95 +79,95 @@
<Version>$(SystemCompositionVersions)</Version>
</PackageReference>
<PackageReference Include="System.ComponentModel.Composition">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Data.DataSetExtensions">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Data.Odbc">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Data.SqlClient">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Diagnostics.PerformanceCounter">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.DirectoryServices">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.DirectoryServices.AccountManagement">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.DirectoryServices.Protocols">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Drawing.Common">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.IO.Packaging">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.IO.Pipelines">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.IO.Ports">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Management">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Net.Http.WinHttpHandler">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Net.WebSockets.WebSocketProtocol">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Runtime.Caching">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Reflection.Context">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Security.Cryptography.ProtectedData">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Security.Cryptography.Pkcs">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Security.Cryptography.Xml">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.ServiceModel.Syndication">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.ServiceProcess.ServiceController">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Text.Encoding.CodePages">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Text.Encodings.Web">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Threading.AccessControl">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Threading.Channels">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Json">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>

</ItemGroup>
<ItemGroup Condition="'$(OSGroup)' == 'Windows_NT'">
<!-- Windows Dependencies -->
<PackageReference Include="Microsoft.Win32.Registry.AccessControl">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="Microsoft.Win32.SystemEvents">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="Microsoft.Diagnostics.Tracing.TraceEvent">
<Version>$(MicrosoftDiagnosticsTracingTraceVentVersion)</Version>
Expand Down
12 changes: 6 additions & 6 deletions tests/src/Common/test_dependencies/test_dependencies.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,22 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.Private.CoreFx.NETCoreApp">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Memory">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Runtime.CompilerServices.Unsafe">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Security.Permissions">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Diagnostics.EventLog">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="System.Drawing.Common">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
</ItemGroup>
<PropertyGroup>
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Common/test_runtime/test_runtime.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NETCore.Platforms">
<Version>$(MicrosoftNETCorePlatformsPackageVersion)</Version>
<Version>$(MicrosoftNETCoreAppVersion)</Version>
</PackageReference>
<PackageReference Include="Microsoft.DotNet.CoreCLR.TestDependencies">
<Version>1.0.0-prerelease</Version>
Expand Down
2 changes: 1 addition & 1 deletion tests/src/Interop/COM/NETClients/Primitives/NETClientPrimitives.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<ProjectReference Include="../../NativeServer/CMakeLists.txt" />
<ProjectReference Include="../../../../Common/CoreCLRTestLibrary/CoreCLRTestLibrary.csproj" />
<PackageReference Include="System.Drawing.Common">
<Version>$(MicrosoftPrivateCoreFxNETCoreAppPackageVersion)</Version>
<Version>$(MicrosoftPrivateCoreFxNETCoreAppVersion)</Version>
</PackageReference>
</ItemGroup>
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
Expand Down
8 changes: 4 additions & 4 deletions tests/src/JIT/Regression/JitBlue/GitHub_20958/GitHub_20958.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@ public static int IndexerWithRangeTest()
int returnVal = 100;

ReadOnlySpan<char> span = "Hello".AsSpan();
ReadOnlySpan<char> sliced = span[Range.Create(new Index(1, fromEnd: false), new Index(1, fromEnd: true))];
ReadOnlySpan<char> sliced = span[new Range(new Index(1, fromEnd: false), new Index(1, fromEnd: true))];
if (span.Slice(1, 3) != sliced)
{
returnVal = -1;
}
try
{
ReadOnlySpan<char> s = "Hello".AsSpan()[Range.Create(new Index(1, fromEnd: true), new Index(1, fromEnd: false))];
ReadOnlySpan<char> s = "Hello".AsSpan()[new Range(new Index(1, fromEnd: true), new Index(1, fromEnd: false))];
returnVal = -1;
}
catch (ArgumentOutOfRangeException)
Expand All @@ -34,14 +34,14 @@ public static int IndexerWithRangeTest()
returnVal = -1;
}
Span<char> span1 = new Span<char>(new char[] { 'H', 'e', 'l', 'l', 'o' });
Span<char> sliced1 = span1[Range.Create(new Index(2, fromEnd: false), new Index(1, fromEnd: true))];
Span<char> sliced1 = span1[new Range(new Index(2, fromEnd: false), new Index(1, fromEnd: true))];
if (span1.Slice(2, 2) != sliced1)
{
returnVal = -1;
}
try
{
Span<char> s = new Span<char>(new char[] { 'H', 'i' })[Range.Create(new Index(0, fromEnd: true), new Index(1, fromEnd: false))];
Span<char> s = new Span<char>(new char[] { 'H', 'i' })[new Range(new Index(0, fromEnd: true), new Index(1, fromEnd: false))];
returnVal = -1;
}
catch (ArgumentOutOfRangeException)
Expand Down
Loading