-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Use dependency flow for core-setup and corefx dependencies #22544
Conversation
Also, @sbomer this unblocks the fixed version of |
Looks like the failure comes from changes in dotnet/corefx#35207 with #22331 where the surface area of |
@mikem8361 Not sure if this is what you needed for your CoreFX testing efforts. |
@@ -10,6 +10,8 @@ | |||
</RestoreSources> | |||
</PropertyGroup> | |||
|
|||
<Import Project="eng/Versions.props" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this would be done from a file like Directory.Build.props
, but most of our tests are not SDK projects so it wouldn't get picked up.
@dotnet-bot test Ubuntu x64 Checked CoreFX Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
@dotnet-bot help |
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
Welcome to the dotnet/coreclr Perf help The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
Welcome to the dotnet/coreclr Repository The following is a list of valid commands on this PR. To invoke a command, comment the indicated phrase on the PR The following commands are valid for all PRs and repositories. Click to expand
The following jobs are launched by default for each PR against dotnet/coreclr:master. Click to expand
The following optional jobs are available in PRs against dotnet/coreclr:master. Click to expand
Have a nice day! |
SPC signing got broken when dotnet#22544 unpinned the SignTool version. Pin the tool version again until issue gets fixed. @jashook
…reclr#22544) * Remove old use of signing package used to work around SPC signing now that arcade has bubbled up the version. * Move dependency update for CoreFX and Core-setup dependencies to BAR/Darc/Maestro++ flow * Update property references in tests. * Version bump for CoreFX and Core-Setup dependencies. * Update test Github_20958 to use revised System.Range constructor as surface area changed with dotnet/coreclr#22331. Commit migrated from dotnet/coreclr@ebaa5dd
Starts to use Maestro++ subcriptions to update versions for:
Microsoft.NETCore.App
Microsoft.Private.CoreFx.NETCoreApp
Microsoft.NETCore.Platforms
The subscriptions are already running, we just need to add the packages to the version files with this PR.
Packages that we still need to get into the new dependency flow:
Buildtools will likely remain using the old update logic until it becomes deprecated.