Remove usings from templates implicitly added by the SDK #34219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DamianEdwards
added
the
blocked
ghost
added
the
area-mvc
5 tasks
DamianEdwards
force-pushed
the
damianedwards/33947-global-usings
branch
from
df76a76
to
fdb2769
Compare
-Depends on dotnet/sdk#18459 flowing to dotnet/aspnetcore repo before we can merge this - There's a couple of places we could remove usings from .razor files but need to verify the global usings flow into Razor compiler (#34217) - Reordered usings in some places to ensure they get emitted in alphabetical order (modulo System.* & Microsoft.* coming before any others)
DamianEdwards
force-pushed
the
damianedwards/33947-global-usings
branch
from
fdb2769
to
e14672c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
captainsafia
added a commit
that referenced
this pull request
Jul 11, 2021
)" This reverts commit d8bba72.
dotnet-maestro bot
added a commit
that referenced
this pull request
Jul 12, 2021
[main] Update dependencies from dotnet/efcore dotnet/runtime - Workaround duplicate logging source generator - Merge branch 'main' into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720 - Fix CS8795 https://dev.azure.com/dnceng/public/_build/results?buildId=1222936&view=logs&jobId=b5df7d42-2bda-5dee-96bd-1838a4f7499c&j=b5df7d42-2bda-5dee-96bd-1838a4f7499c&t=c1ffdaa9-e800-5fe8-052c-643f2e9f52ff - Update Wasm.Performance.TestApp.csproj - Fix skipEnabledCheck - Merge branch 'main' into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720 - Update Workarounds.targets - Revert "Fix CS8795" This reverts commit a2ec9d6. - Revert "Convert HealthChecks logging to use new Logging Source Generator (#32414)" This reverts commit 1dd00f4. - Utilize class level SkipEnabledCheckLogOptions - React to MvcCoreLoggerExtensions feedback - Merge remote-tracking branch 'origin/main' into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720 - React to nullability changes in TypeConverter - Merge branch 'main' into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720 - React to new analyzer warnings - Revert "Revert "Convert HealthChecks logging to use new Logging Source Generator (#32414)"" This reverts commit 5d6e21e. - Update src/Http/Routing/src/Matching/DfaMatcher.cs Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com> - Update exception caught in HTTP2 tests - Merge branch 'main' of https://github.com/dotnet/aspnetcore into darc-main-1709b9ed-50a0-4e28-b9b8-0e3759aee720 - Revert "Remove usings from templates implicitly added by the SDK (#34219)" This reverts commit d8bba72. - Fix up exceptions for HTTP2 tests - Revert "Revert "Remove usings from templates implicitly added by the SDK (#34219)"" This reverts commit cce1bd7. - Bump up SDK to bring in usings changes - Try running template tests on non-Helix - Update ci.yml - Try disabling template tests on Helix - Revert "Stop running template tests on azdo job (already helix-ified) (#32985)" This reverts commit 7a842b7. - Don't build Helix payload for template tests - Temporarily skip FrameworkListListsContainsCorrectPaths - Use dotnet test for test discovery - Revert "Use dotnet test for test discovery" This reverts commit f5cecb2. - Try skipping listing tests list in helix - Revert "Try disabling template tests on Helix" This reverts commit 2136f31. - Remove generic type from test method - Removed another generic from the test method
dougbu
removed
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
System.*&Microsoft.*coming before any others)Contributes to #33947 #33948