Update SDK #34236
Update SDK #34236
Conversation
This ingests the global imports change from the SDK
ghost
added
the
area-infrastructure
JunTaoLuo
requested review from
BrennanConroy,
halter73 and
Tratcher
as code owners
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.targets))\Directory.Build.targets" /> | ||
|
|
||
| <ItemGroup> | ||
| <Import Remove="System.Net.Http" /> |
There was a problem hiding this comment.
There is a type name conflict between System.Net.Http.HttpMethod and Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.HttpMethod.
Seems like this was the only conflict in our repo so I just removed it for kestrel.
There was a problem hiding this comment.
Ok, so this removes the default using System.Net.Http?
There was a problem hiding this comment.
This is an interesting problem. It finally bit in the butt.
There was a problem hiding this comment.
I'm impressed that this is the only instance.
| @@ -5,5 +5,6 @@ | |||
| <IsPackable>false</IsPackable> | |||
| <DisablePackageReferenceRestrictions>true</DisablePackageReferenceRestrictions> | |||
| <Nullable>disable</Nullable> | |||
| <DisableImplicitNamespaceImports>true</DisableImplicitNamespaceImports> | |||
There was a problem hiding this comment.
The tools use Microsoft.Build.Tasks which conflicts with System.Threading.Tasks. Since it's just tools, I just disabled everything instead of just the specific conflicts.
There was a problem hiding this comment.
Why does it conflict? Because we don't have the new compiler that hides these conflict warnings? Can you clarify?
There was a problem hiding this comment.
It's not a warning, it's an error for ambiguous types.
error CS0104: 'Task' is an ambiguous reference between 'Microsoft.Build.Utilities.Task' and 'System.Threading.Tasks.Task
This ingests the change dotnet/sdk#18459 into our repo.
FYI @captainsafia @Tratcher since this will overlap your ops rotations, probably.