Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CustomEvent for PubSub and TypedEventTarget impl #1761

Merged
merged 3 commits into from
Sep 20, 2022
Merged

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Sep 20, 2022

Closes #1485
Closes #1484

@ardatan ardatan requested a review from n1ru4l September 20, 2022 11:57
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022

🦋 Changeset detected

Latest commit: c043cf0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@graphql-yoga/redis-event-target Major
@graphql-yoga/subscription Major
@graphql-yoga/typed-event-target Major
graphql-yoga Patch
@graphql-yoga/common Patch
@graphql-yoga/node Patch
@graphql-yoga/render-graphiql Patch
@graphql-yoga/plugin-apollo-inline-trace Patch
@graphql-yoga/plugin-apq Patch
@graphql-yoga/plugin-persisted-operations Patch
@graphql-yoga/plugin-response-cache Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
hackernews Patch
hello-world-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/redis-event-target 1.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/typed-event-target 1.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 2.4.3-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
graphql-yoga 3.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎
@graphql-yoga/subscription 3.0.0-alpha-20220920122139-82741cee npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 166358      ✗ 0    
     data_received..................: 25 MB   826 kB/s
     data_sent......................: 9.6 MB  319 kB/s
     http_req_blocked...............: avg=1.19µs   min=800ns   med=1µs     max=320.2µs p(90)=1.5µs   p(95)=1.9µs  
     http_req_connecting............: avg=1ns      min=0s      med=0s      max=127.4µs p(90)=0s      p(95)=0s     
   ✓ http_req_duration..............: avg=282.04µs min=192.3µs med=256.2µs max=21.35ms p(90)=319.1µs p(95)=352.5µs
       { expected_response:true }...: avg=282.04µs min=192.3µs med=256.2µs max=21.35ms p(90)=319.1µs p(95)=352.5µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 83179
     http_req_receiving.............: avg=19.56µs  min=10.8µs  med=17.89µs max=8.21ms  p(90)=24µs    p(95)=26.5µs 
     http_req_sending...............: avg=7.76µs   min=4.1µs   med=5.5µs   max=3.45ms  p(90)=11µs    p(95)=11.8µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=254.71µs min=173µs   med=230.9µs max=21.23ms p(90)=288.1µs p(95)=318.9µs
     http_reqs......................: 83179   2772.474385/s
     iteration_duration.............: avg=353.8µs  min=251µs   med=324.5µs max=21.93ms p(90)=404.4µs p(95)=438.2µs
     iterations.....................: 83179   2772.474385/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Sep 20, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://4a73f6a7.graphql-yoga.pages.dev

@n1ru4l
Copy link
Collaborator

n1ru4l commented Sep 20, 2022

Screenshot 2022-09-20 at 14 13 34

found this lol


should we also remove the option of people providing their own eventAPI polyfill?

@ardatan
Copy link
Collaborator Author

ardatan commented Sep 20, 2022

@n1ru4l Haha. Fixed it.

should we also remove the option of people providing their own eventAPI polyfill?

I don't think we still have it in v3 currently.

@n1ru4l
Copy link
Collaborator

n1ru4l commented Sep 20, 2022

@ardatan all good then!

Copy link
Collaborator

@n1ru4l n1ru4l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg

@ardatan ardatan merged commit b2407c6 into v3 Sep 20, 2022
@ardatan ardatan deleted the custom-event branch September 20, 2022 12:22
This was referenced Sep 21, 2022
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CustomEvent instead of Event Use a separate Event API polyfill package
2 participants